ansaurus

Question

Variables behaving badly - in javascript - in functions

Answer 1

A:

Try:

 var variable1 = 10;
 var f1 = function(){
     alert(variable1);
 }
 //When button is pressed, call function
 $("#button").click(f1);

Too hungover to explain. Sorry!

Commenters are correct, ignore the above. Just mocked up your issue. Your code works fine for me:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"&gt;
<html xmlns="http://www.w3.org/1999/xhtml"&gt;
 <head>
  <title>
   test
  </title>

  <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js"&gt;&lt;/script&gt;
 </head>
 <body>
  <div id="button">hello</div>
  <script type="text/javascript">
   //<![CDATA[
    var variable1 = 10;
    function f1 (){
     alert(variable1);
    }
    //When button is pressed, call function
    $("#button").click(f1);

   //]]>
  </script>
 </body>
</html>

spender 2009-12-26 19:25:05

function x() { ... } is syntactic sugar for var x = function () { ... };.

AKX 2009-12-26 19:26:53

this will also fail

streetparade 2009-12-26 19:27:07

My hangover bigger than my programming powers...

spender 2009-12-26 19:31:59

I must have simplified my problem incorrectly. I'll come back with the correct question as soon as possible.

Patrick Beardmore 2009-12-26 19:36:34

@AKX, actually, they're both VERY different - http://yura.thinkweb2.com/named-function-expressions/

J-P 2009-12-26 22:51:20

@J-P: Thanks for the clarification! I must've mixed Lua and JS up. In Lua, I'm fairly sure function x() end is sugary...

AKX 2009-12-27 01:13:27

Answer 2

A:

I'm quite sure that you can access variable1 from inside of f1. What happens when you try?

~~One thing I notice is that you're calling alert with an int argument. I'm not sure if that works. Try~~

~~alert(variable1.toString());~~

~~instead.~~

EDIT: OK, never mind that bit; alert(int) certainly does work.

Dan Breslau 2009-12-26 19:26:22

Answer 3

+1 A:

Your problem is actually not that you can't access the variable, but that the #button element is not in the DOM yet when your binding code is called. Wrap your initialization code in the jQuery DOM ready idiom:

$(document).ready(function() {
    $("#button").click(f1);
});

AKX 2009-12-26 19:36:57

I think you've nailed it.

Dan Breslau 2009-12-26 19:40:57

This is only a snippet of much more code so that isn't the problem.

Patrick Beardmore 2009-12-26 19:41:01

Answer 4

+1 A:

Here's the definitive answer to what my problem was, courtesy of this website. I foolishly named one of my variables the same as an id and a function. Insanity! I apologise for wasting people's boxing days. Thanks for all your help.

Patrick Beardmore 2009-12-26 23:26:21

ansaurus

tags:

views:

answers:

Variables behaving badly - in javascript - in functions

Modified question

related questions