ansaurus

Question

Answer 1

+3 A:

you need to escape the string you are writing out into DoEdit to scrub out the double-quote characters, they are causing the onclick HTML attribute to close prematurely.

Using the Javascript escape character, \, isn't sufficient in the HTML context, you need to replace the double-quote with the proper XML entity representation, "

Aaron 2010-01-05 04:34:03

Right, but wouldn't that be this?<a href="#" onclick="DoEdit('Preliminary Assessment \"Mini\"'); return false;">edit</a>I tried that, and it is still screwing up. This has got to be a simple WTF but for the life of me, I can't see it.

Matt Dawdy 2010-01-05 04:35:40

And evidently I can't read. Thanks for the answer.

Matt Dawdy 2010-01-05 05:57:14

Is there any built-in JavaScript function that would escape the double quotes ?Apart from 'quo"'.replace('"', '"') I can't find anything.

kevin 2010-08-18 14:39:12

It's not a javascript issue, it's an HTML/XML encoding issue: you can't have double-quote characters inside an attributes value w/o escaping them... otherwise browsers/parsers think you're ending the attribute value declaration.

Aaron 2010-08-21 07:09:19

Answer 2

A:

I have done a sample one using jQuery

var descr = 'test"inside"outside';
$(function(){
   $("#div1").append('<a href="#" onclick="DoEdit(descr);">Click Me</a>');       
});

function DoEdit(desc)
{
    alert ( desc );
}

and this works in IE and FF.

rahul 2010-01-05 04:40:24

Of course it does, because you aren't putting it directly in the attribute. To use your method, I'd have to create an array of JS strings, then do an arbitrary number of $("#divxxx")... assignments. Less than optimal, but thanks for the suggestion.

Matt Dawdy 2010-01-05 05:14:37

Answer 3

+2 A:

The problem is that html doesn't recognize the escape character. You could work around that by using the single quotes for the html attribute and the double quotes for the onclick.

<a href="#" onclick='DoEdit("Preliminary Assessment \"Mini\""); return false;'>edit</a>

dl 2010-01-05 04:44:01

Yikes. I was wondering why I naturally resorted to using ' for the attribute in the past. I just never delved into it all that deeply. Thanks.

Matt Dawdy 2010-01-05 05:15:26

Answer 4

+1 A:

<html>
    <body>
        <a href="#" onclick="DoEdit('Preliminary Assessment &quot;Mini&quot;'); return false;">edit</a>
    </body>
</html>

Should do the trick.

kristian 2010-01-05 05:27:25

Sheesh. Thanks for that! Works perfectly.

Matt Dawdy 2010-01-05 05:55:38

Answer 5

A:

What about escaping whitespace as well. It sounds to me like firefox is assuming three arguments instead of one.   is the non-breaking space character. Even if it's not the whole problem, it may still be a good idea.

the Hampster 2010-01-05 06:08:24

ansaurus

tags:

views:

answers:

Javascript escape quotes

related questions