views:

151

answers:

3

Is this legal? Does it contain a hidden bug or flaw? Visual studio does not give any errors or warnings but ReSharper does:

/// <summary>
/// immutable tuple for two
/// </summary>
public class Pair<TValue1, TValue2> : Singleton<TValue1>
{
    public TValue2 Value2 { get; private set; }
    public Pair(TValue1 value1, TValue2 value2, Func<Pair<TValue1, TValue2>, String> toStringFunc)
        : this(value1, value2, () => toStringFunc(this)) { } //Red light

}2> : Singleton<TValue1>
+5  A: 

I'm pretty sure I've heard that this is a compiler bug, fixed in the next release. I'm just firing up my 4.0 VM, with a simpler test-case:

class Foo {
    public Foo() : this(delegate { this.Bar(); }) { }
    public Foo(Action foo) {}
    public void Bar() {}
}

works in VS2008, but in VS2010:

Error 1 Keyword 'this' is not available in the current context

Marc Gravell
Yep. My bad. Sorry!
Eric Lippert
Fix the null/struct warning and I'll forgive you ;-p
Marc Gravell
+2  A: 

This is a bug in the C# 3 compiler that is fixed in C# 4.

Edit:
http://stackoverflow.com/questions/1875975/corner-case-in-using-lambdas-expression-in-base-constructor/1876263#1876263

Tinister
A: 

Your constructor will loop forever, until it pops the stack. This is because it keeps calling itself recursively. Try splitting it up:

public Pair(TValue1 value1, TValue2 value2)
    : this(value1, value2, () => toStringFunc(this)) { }

public Pair(TValue1 value1, TValue2 value2, Func<Pair<TValue1, TValue2>, String> toStringFunc)
    { /* some actual logic */ }
Sean Devlin