refactor dilemma

Question

I want to extract the guard statement from the following method

private void CreateProxy()
    {
        //extract the following guard statement.
        Host selected = this.comboBox1.SelectedItem as Host;
        if (selected == null)
        {
            return;
        }


        this.SearchProxy = ServiceProxy.ProxyFactory.CreateSearchProxy(GetSelectedIP().ToString());
        this.StreamProxy = ServiceProxy.ProxyFactory.CreatePlayerProxy(GetSelectedIP().ToString());
    }

     //extracted guard method
     public bool IsHostSelected()
     {
        Host selected = this.comboBox1.SelectedItem as Host;
        if (selected == null)
        {
            return false;
        }
        return true;
     }

see? now i have to add return value for the extracted method, is this kinda ugly?

any better solution to avoid adding the return value for the extracted method?

Answer 1

any better solution to avoid adding the return value for the extracted method?

Yes:

 //extracted guard method
 public bool IsHostSelected()
 {
    Host selected = this.comboBox1.SelectedItem as Host;
    return selected != null;
 }

Answer 2

I don't see the big deal. First, I would rewrite it as:

static bool SelectedItemIsHost(ComboBox box)  { 
    return box.SelectedItem is Host;
}

Note the rename, the ComboBox as a parameter, and the body change.

Now, this makes your code read more clearly:

void CreateProxy() {
    if(SelectedItemIsHost(this.comboBox1)) {
        this.SearchProxy = ServiceProxy.ProxyFactory.CreateSearchProxy(GetSelectedIP().ToString());
        this.StreamProxy = ServiceProxy.ProxyFactory.CreatePlayerProxy(GetSelectedIP().ToString());
    }
}

So now it reads "if the selected item is a Host then do stuff."

Now, this goes way beyond your question, but this looks like a big coupling of UI logic and domain logic. You might want to reconsider a decoupling there.