tags:

views:

137

answers:

5

Hello I have some issue while exit loop,variable is 0 ,please se code below

max=0
cat tmp|while read line
do
temp=$(echo $line|tr -d "\n"|wc -c)
if [ $temp -gt $max ];then

max=$temp
echo $max
fi
done
echo -n tmp $max

cat tmp
12345
123456
OUTPUT
5
6
 tmp 0

I can't understand why max 0 after exiting loop,because iside the loop it getcorrect values

+3  A: 

A pipe starts a new subshell, with its own environment and variable space. Use < tmp at the end of the loop instead.

Ignacio Vazquez-Abrams
yes you right I fix it and now it is work, but I am not sure that pipe open new subshel whith variables ,as I understand it just an input buffer for new commands
Leo
I​ a​m​ ​s​ure.
Ignacio Vazquez-Abrams
+1  A: 
max=0
while read line
do
    temp=$(echo $line|tr -d "\n"|wc -c)
    if [ $temp -gt $max ]
    then 
        max=$temp
        echo $max
    fi
done <tmp
echo -n tmp $max
Paul Creasey
+1  A: 

The pipe before your while is putting everything inside the loop into a separate shell, and thus a separate identifier context (essentially a new environment).

Redirecting the tmp file into the while loop via < will keep your loop and variables all in the same execution context.

while read line
do
    # your loop stuff 
done < tmp
dustmachine
A: 

According to the bash man page each command in a pipeline is executed in a subshell. That is, your while loop runs in a subshell and only the value of the variable max in that subshell is modified.

Variables of subshells are not propagated back to the calling shell, which is running the echo command and thus still sees the initial zero value.

If you run the echo in the same subshell (note the curly braces) it will work:

max=0
cat tmp|{
    while read line
    do
        temp=$(echo $line|tr -d "\n"|wc -c)
        if [ $temp -gt $max ];then
            max=$temp
        fi
    done
    echo -n tmp $max
}

If you need the value for further calculations in the outer shell, you would need to use command substitution like this:

max=0
max=$(cat tmp|{
    while read line
    do
        temp=$(echo $line|tr -d "\n"|wc -c)
        if [ $temp -gt $max ];then
            max=$temp
        fi
    done
    echo -n $max
})
echo tmp $max
deepwaters
A: 

Here's a one liner in awk.

$ awk 'length>t{t=length}END{print t}' file
6
ghostdog74