App crash when calling MessageBox

Question

Hello i call up a MessageBox when validating some data, if the data is wrong I message the user with a MessageBox with following code:

private void button1_Click(object sender, EventArgs e)
{
    if (textBox_name.Text.Trim() != "" 
        || textBox_X.Text.Trim() != "" 
        || textBox_Y.Text.Trim() != "")
    {
        if (graph.getNodoNome(textBox_nome.Text.Trim()) != null)
        {
            MessageBox.Show("Data is wrong?", "Error");

            resetTextBoxes();
            return;
        }

    // randome stuff
    }
}

My app crash with this, when i remove the MessageBox works fine. Thanks for the help

EDIT: Pastebay link for the entire method http://pastebay.com/82690

Answer 1

I think we need more info on the "graph.getNodoNome" and "randome stuff" parts. If you comment out those lines, it runs just fine. I pretty much guarantee the message box is not the problem.

I would bet it’s the getNodoNome method or the random stuff that is getting you.

1) Comment them both out, and see if it "crashes." 2) Uncomment the first "graph.getNodoNome" and see if it crashes 3) Comment out "graph..." uncomment "randome stuff" and see if it crashes

If you're not getting error messages, you need to take baby steps.

Answer 2

You should mention the type of exception.

Since I can't assume that, I'll comment on other potential sources of error?

Honestly also, your

        if (textBox_nome.Text.Trim() != "" 
            || textBox_X.Text.Trim() != "" 
            || textBox_Y.Text.Trim() != "")

should be

        if (textBox_nome.Text.Trim() != "" 
            && textBox_X.Text.Trim() != "" 
            && textBox_Y.Text.Trim() != "")

to make sure all fields are filled in.

Int.Parse will throw if invalid, I suggest (in pseudo C#):

int x;
if(!int.TryParse(text, out x)) x = 0; // some default value