ansaurus

Question

Using Javascript to replace Text in HTML tag with innerHTML and functions

Answer 1

+1 A:

How about merging the init and writeGreeting functions:

window.onload = init;

function init() 
{
 var fullname=prompt("Please Enter you name!","Anonymous ");
 fullname = (fullname == "Anonymous")? "Anonymous " : "";

 var nickname=prompt("Please Enter you nickname!"," None");
 nickname = (nickname == "None")? " None": ""; 
 document.getElementById("greeting").innerHTML= "Welcome " + fullname + " (" + nickname + ")";
}

p.s. Minor point of grammar - you probably want "Please enter your name", rather than "Please Enter you name", and similarly for the nickname prompt.

Dominic Rodger 2010-01-14 12:22:41

Answer 2

A:

// Create two GLOBAL variables
var fullname = "";
var nickname = "";

function init() {
  fullname = /* ... */
  nickname = /* ... */
  // pass the nickname on to the greeting function
  writeGreeting(nickname);
}

// This function is remain separate, if you wish to call it again
// at a later time before a page-refresh.
function writeGreeting(name) {
  document.getElementById("greeting").innerHTML = name;
}

Jonathan Sampson 2010-01-14 12:23:29

Answer 3

A:

How about like this?

It will display "Welcome fullname!" or "Welcome nickname!" or "Welcome Anonymous!" if you don't put any.

function init() {
     var fullname=prompt("Please Enter you name!");
     var nickname=prompt("Please Enter you nickname!");
     writeGreeting(fullname||nickname||"Anonymous");
}

function writeGreeting(name){
    document.getElementById("greeting").innerHTML= "Welcome "+name+"!";
}

S.Mark 2010-01-14 12:32:18

Answer 4

A:

I like Dominic's solution. Just bear in mind that you should be careful with any data entered by a user. I would recommend escaping string with escape() function, prior to using it.

e.g.

document.getElementById("greeting").innerHTML= "Welcome " + escape( fullname ) +
                                               " (" + escape( nickname ) + ")";

Vladimir Kocjancic 2010-01-14 12:33:28

bobince 2010-01-14 13:03:27

Ah. Yet, you have to agree that it is still better than nothing. :)

Vladimir Kocjancic 2010-01-14 13:17:25

Answer 5

+1 A:

Why not use .innerText instead?

burak ozdogan 2010-01-14 12:50:44

Because it's IE-only. On other recent browsers you can use the DOM Level 3 Core property `textContent` instead. But yes, you definitely don't want to be writing unescaped text to `innerHTML`.

bobince 2010-01-14 13:05:21

Answer 6

A:

Try this. Tested with ie, chrome and ff (all latest).

var msg = "Welcome " + fullname + "(" + nickname + ")!";

var greetingElement = document.getElementById("greeting");

if(greetingElement.firstChild == null)
    greetingElement.appendChild(document.createTextNode(msg));
else
    greetingElement.firstChild.nodeValue = msg;

gp 2010-01-14 17:45:17

Answer 7

A:

how are you? please help me i have project talk about school and i want to make login for the student and teacher to reterive schedual thanks alote

Alaa 2010-01-18 19:23:33

ansaurus

tags:

views:

answers:

Using Javascript to replace Text in HTML tag with innerHTML and functions

related questions