tags:

views:

83

answers:

4

If a bash script has set -e, and a command in the script returns an error, how can I do some cleanup before the script exits?

For example:

#!/bin/bash
set -e
mkdir /tmp/foo
# ... do stuff ...
rm -r /tmp/foo

How can I ensure that /tmp/foo is removed, even if one of the commands in ... do stuff ... fails?

+1  A: 

From the reference for set:

-e

Exit immediately if a simple command (see section 3.2.1 Simple Commands) exits with a non-zero status, unless the command that fails is part of an until or while loop, part of an if statement, part of a && or || list, or if the command's return status is being inverted using !. A trap on ERR, if set, is executed before the shell exits.

(Emphasis mine).

Anon.
+4  A: 

From the bash manpage (concerning builtins):

trap [-lp] [[arg] sigspec ...]
The command arg is to be read and executed when the shell receives signal(s) sigspec.

So, as indicated in Anon.'s answer, call trap early in the script to set up the handler you desire on ERR.

dmckee
You can also trap on EXIT.
Dennis Williamson
+1  A: 

here is a reference for you on trapping signals and set -e related. Have a look.

ghostdog74
Ah, that is useful - thanks.
David Wolever
+4  A: 

Here's an example of using trap:

#!/bin/bash
set -e
function cleanup {
  echo "Removing /tmp/foo"
  rm  -r /tmp/foo
}
trap cleanup EXIT
mkdir /tmp/foo
asdffdsa #Fails

Output:

dbrown@luxury:~ $ sh traptest
t: line 9: asdffdsa: command not found
Removing /tmp/foo
dbrown@luxury:~ $

Notice that even though the asdffdsa line failed, the cleanup still was executed.

cygnl7
Cool, that's exactly what I was hoping for. Thanks!
David Wolever