show/hide works with JQuery 1.3.2 but not JQuery 1.4

Question

I have a function which submits data to my server, and then removes the edit UI and replaces it with the regular UI. This works perfectly under JQuery 1.3.2 but does not work with JQuery 1.4.0. Any ideas?

function save_edit(point_id) {
  var data = {};
  data.id = point_id;
  $.post("/foo", data, function(responseData) {
    $("#value" + point_id).show();
    $("#editval" + point_id).hide();
  }, "json");
}

Answer 1

jQuery 1.4 using strict JSON parsing, as mentioned in the release notes. Is your data valid JSON?

Answer 2

jQuery 1.4 is very picky about valid JSON response text. The following is not valid JSON (and most likely your problem)

 {foo:'bar'}

 // Strict JSON requires quoted attributes - and the quotes must be doubles!

 {"foo": "bar"}

This blog post mentions a workaround using 'text' instead if you can't fix the serverside JSON easily. Applied to your function you get:

function save_edit(point_id) {
  var data = {};
  data.id = point_id;
  $.post("/foo", data, function(responseText) {
    var responseData = eval("("+responseText+")");
    $("#value" + point_id).show();
    $("#editval" + point_id).hide();
  }, "text");
}

Also, you would be able to handle an error case doing something like this:

function save_edit(point_id) {
  var data = {};
  data.id = point_id;
  var $edit = $("#editval"+point_id);
  var $view = $("#value"+point_id);
  $.ajax({
    method: "POST",
    url: "/foo", 
    data: data, 
    success: function(responseData) {
      $view.show();
      $edit.hide().find('.error').remove();
    },
    error: function(XHR, textStatus, errorThrown) {
      var $err = $edit.find(".error");
      if ($err.length == 0) { $err = $("<div class='error'/>").appendTo($edit); }
      $err.text("Error: "+textStatus);
    }
  });
}