ansaurus

Question

Jquery, Click / If Else function, Not working

Answer 1

+1 A:

You ought to use the .show() and .hide() methods really as what you're trying to do is what they were designed for.

You need to wrap your code into a function that will get executed when the ready event is raised

$(function() { /* code here */ });

So it should be like so

$(function() {

    $('#portweb').click(function() {

        if ('li[value*=web] img'.hasClass("hide")) {
            $('li[value*=web] img').removeClass('hide').addClass('show');
        }
        else if ('li[value*=web] img'.hasClass("show")) {
            $('li[value*=web] img').removeClass('show').addClass('hide');
        }

    });

});

Russ Cam 2010-02-10 17:49:25

Thanks for the response Russ!

Starboy 2010-02-10 17:58:40

No probs. I would cache the jQuery object in a variable too so that you don't search the Dom each time to get the same elements

Russ Cam 2010-02-10 18:55:28

Answer 2

A:

You are trying to manipulate the DOM before it is ready. Try wrapping your code in a document.ready statement. Also in your ifs you are trying to call the hasClass method on a string which is not defined:

$(function() {

    $('#portweb').click(function() {

        if ($('li[value*=web] img').hasClass("hide")) {
            $('li[value*=web] img').removeClass('hide').addClass('show');
        }
        else if ($('li[value*=web] img').hasClass("show")) {
            $('li[value*=web] img').removeClass('show').addClass('hide');
        }

    });

});

Darin Dimitrov 2010-02-10 17:49:26

Thanks Darin, this did work. Now I had this at one time in a $(document).ready(function(){ }); and still had no success, but thank you for your response. (this brought up another problem actually)

Starboy 2010-02-10 17:57:31

Answer 3

A:

Try changing your if conditional to something like this:

if ($('li[value*=web] img').hasClass("hide")) {
        $('li[value*=web] img').removeClass('hide').addClass('show');
    }
    else if ($('li[value*=web] img').hasClass("show")) {
        $('li[value*=web] img').removeClass('show').addClass('hide');
    }

Keith Rousseau 2010-02-10 17:50:35

ansaurus

tags:

views:

answers:

Jquery, Click / If Else function, Not working

related questions