So i have a function that needs to check if an argument is an object, but this fails because:
typeof [] // returns 'object'
This is a classic javascript gotcha, but i cant remember what to do to actually accept objects, but not arrays.
views:
108answers:
3
+2
A:
Try something like this :
obj.constructor.toString().indexOf(”Array”) != -1
or (even better)
obj instanceof Array
Thomas Wanner
2010-02-15 12:42:01
it seems your first suggestion is the most safe one and would also fix the problem stated by @Pointy below.Thank you :)
hojberg
2010-02-15 13:04:23
or to be more exact: Object.prototype.toString.call(obj) === '[object Array]';
hojberg
2010-02-15 13:05:39
jQuery has a utility method `isArray()`. http://api.jquery.com/jQuery.isArray/@hojberg I back your way of doing it. jQuery Internally does the same.
Teja Kantamneni
2010-02-15 14:12:54
+2
A:
Have you tried this:
var test = [];
if(test instanceof Array) {
...
}
EDIT: This method doesn't work in multi-frame DOM environments (‘typeof’ considered useless - or how to write robust type checks). (via Pointy)
Arnold Zokas
2010-02-15 12:44:15
Not really a good solution. See http://juhukinners.com/2009/01/11/typeof-considered-useless-or-how-to-write-robust-type-checks/
Pointy
2010-02-15 13:07:37
+1
A:
All these answers suggesting that you check to see (one way or another) if an object is an instance of the "Array" class (that is, constructed by "Array") are really not safe solutions. They'll work sometimes, maybe most of the time, but all the major frameworks have moved away from that approach. One of the main problems with it comes about when there's interaction between multiple windows (generally, a parent window and one or more frame or iframe windows). If you pass an array object created in one window into an API resident in another window, all these tests will fail. Why? Because what you're testing is whether an object is an instance of the "Array" class in your local window context. In other words, when you reference "Array" in
if (myobject instanceof Array) { ... }
what you're referencing is window.Array, of course. Well, an array constructed in another window is not going to be an instance of the Array class in your window!
Checking the constructor name is probably a little safer, though it's still risky. In my opinion, you're better off taking a duck-typing approach. That is, instead of asking, "Is this an Array?" ask instead, "does this object seem to support some particular set of Array APIs I need in this circumstance?" For example, "does this object have a length property?" Javascript is a pretty "soft" language, and just about everything's mutable. Thus even if you do find out something was constructed by "Array", you still really don't know for sure what you can do with it or to it.
[edit] Thanks for that link, @Lachlan - here's a very clear description of the issues: http://juhukinners.com/2009/01/11/typeof-considered-useless-or-how-to-write-robust-type-checks/
Pointy
2010-02-15 12:51:50