views:

397

answers:

5

I'm constructing a method to take in an ArrayList(presumably full of objects) and then list all the fields(and their values) for each object in the ArrayList.

Currently my code is as follows:

public static void ListArrayListMembers(ArrayList list)
    {
        foreach (Object obj in list)
        {
            Type type = obj.GetType();
            string field = type.GetFields().ToString();
            Console.WriteLine(field);

        }
    }

Of course, I understand the immediate issue with this code: if it worked it'd only print one field per object in the ArrayList. I'll fix this later - right now I'm just curious how to get all of the public fields associated with an object.

EDIT: Sorry for flip-flopping answers so much. I should have tried every method before selecting an answer.

+6  A: 
foreach (Object obj in list) {
    Type type = obj.GetType();

    foreach (var f in type.GetFields().Where(f => f.IsPublic)) {
        Console.WriteLine(
            String.Format("Name: {0} Value: {1}", f.Name, f.GetValue(obj));
    }         
}

Note that this code requires .NET 3.5 to work ;-)

Dave Markle
Nevermind. I like this technique better. I can just extrapolate this to get properties(and even methods) as well. Thanks a bunch!
junkforce
+2  A: 
public static void ListArrayListMembers(ArrayList list)
{
    foreach (Object obj in list)
    {
        Type type = obj.GetType();
        Console.WriteLine("{0} -- ", type.Name);
        Console.WriteLine(" Properties: ");
        foreach (PropertyInfo prop in type.GetProperties())
        {
            Console.WriteLine("\t{0} {1} = {2}", prop.PropertyType.Name, 
                prop.Name, prop.GetValue(obj, null));
        }
        Console.WriteLine(" Fields: ");
        foreach (FieldInfo field in type.GetFields())
        {
            Console.WriteLine("\t{0} {1} = {2}", field.FieldType.Name, 
                field.Name, field.GetValue(obj));
        }
    }
}

I'd like to mention that looking for IsPublic in the fields is not necessary as type.GetFields() as defined by MSDN states:

Return Value - Type: System.Reflection.FieldInfo[]

An array of FieldInfo objects representing all the public fields defined for the current Type.

nyxtom
What namespace are PropertyInfo and FieldInfo in?
junkforce
System.Reflection
Jon B
System.Reflection
Jonathan Webb
Thanks. And ah, you fixed your bug :p
junkforce
Hey you renigged on my answer :P
nyxtom
@nyxtom: you got my vote because it will work on 2.0 and 3.5
Jonathan Webb
+1  A: 
    static void ListArrayListMembers(ArrayList list)
    {
        foreach (object obj in list)
        {
            Type type = obj.GetType();
            foreach (FieldInfo field in type.GetFields(BindingFlags.Public))
            {
                Console.WriteLine(field.Name + " = " + field.GetValue(obj).ToString());
            }
        }
    }
Jon B
+1  A: 

You can obtain all the object Fields declared directly in the class with the BindingFlags:

GetFields(BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly)

and all object Fields including inherited with:

GetFields(BindingFlags.Public | BindingFlags.Instance)
Jonathan Webb
A: 

Of course, another question would be "why have you got public fields?" - properties being preferable. As an abstraction, note that reflection isn't the only option: it is also possible for a type to expose it's properties on-the-fly at runtime (like how an untyped DataTable/DataView exposes columns as properties).

To support this (while also supporting simple objects), you would use TypeDescriptor:

        foreach(PropertyDescriptor prop in TypeDescriptor.GetProperties(obj))
        {
            Console.WriteLine("{0}={1}", prop.Name, prop.GetValue(obj));
        }

This also allows for numerous extensibility options - for example, vastly speeding up reflection (without changing any code).

Marc Gravell