Calculating the average

Question

This is a related question to one I posted earlier... I'm trying to sum all the input elements that begin with 'pull' and place that total in the 'totalpull' input field. I have that part working. Now, I'm trying to calculate the average if a user enters something manually in the 'totalpull' input field and set each 'pull' input to that value. Trying below, but it doesn't work...

//This is the sum formula, which works
        $('input[name^=pull]').bind('keyup', function() {
                $('#totalpull').val( $('input[name^=pull]').sumValues() );
        });

        $.fn.sumValues = function() {
                var sum = 0; 
                $("input[name^='pull']").each(function() {
                        if ( $(this).is(':input') ) {
                                var val = $(this).val();
                        } else {
                                var val = $(this).text();
                        }
                        sum += parseFloat( ('0' + val).replace(/[^0-9-\.]/g, ''), 10 );
                });
                return sum;
        };


//This is the avg formula, which does not work
//Keep getting v / rowCount.replace is not a function
        $('input[name=totalpull]').bind('keyup', function() {
                $('input[name^=pull]').each(function() {
                        $(this).val( $('input[name=totalpull').avgValues() );
                });
        });
        $.fn.avgValues = function() {
                var avg = 0;
                var v = $("input[name=totalpull").val();
                var rowCount = $("#convertRow tr").length; 
                avg += parseFloat( (v / rowCount).replace(/[^0-9-\.]/g, ''), 10);
                return avg;
        }

<table id="convert">
<tbody>
<tr><td><input type="text" value="" name="pull0" /></td></tr>
<tr><td><input type="text" value="" name="pull1" /></td></tr>
<tr><td><input type="text" value="" name="pull2" /></td></tr>
<tr><td><input type="text" value="" name="pull3" /></td></tr>
</tbody>

<tfoot>
<input type="text" id="totalpull" name="totalpull" value="" />
</tfoot>
</table>

Answer 1

In your sumValues function, you're repeating the 'input[name^=pull]' selector. You should either pass the selector into your function, or act on the values you've already got.

In sumValues, 'this' should be a collection of inputs. Therefore, you should be able to do something like:

$.fn.sumValues = function() {
  var sum = 0;
  this.each(function() {
    sum += $(this).val();
  });
  return sum;
}

You've also got 'input' and ':input' confused. 'input' is an input tag. :input is any input or select tag.

Answer 2

When total sum is changed manually, the value is distributed to "pull*" field:

$('input[name=totalpull]').bind('keyup', function() {
    var inp = $('input[name^=pull]');
    inp.val(parseFloat($(this).val()) / inp.length);
});​

Answer 3

Your immediate problem is just a syntax error:

 avg += parseFloat( (v / rowCount).replace(/[^0-9-\.]/g, ''), 10);

There is no replace on a number. You need a toString thrown in:

 avg += parseFloat( (v / rowCount).toString().replace(/[^0-9-\.]/g, ''), 10 );

BTW, there's also no / for a string (like v is), but JavaScript will try to convert it for you and give you NaN if it can't.