views:

423

answers:

5

For debugging / performance tests I would like to dynamically add logging code to all event handlers of components of a given type at run time.

For example, for all Datasets in a Datamodule, I need to run code in the BeforeOpen and AfterOpen events to capture the start time, and to log the elapsed time in AfterOpen.

I would prefer to do this dynamically (no component subclassing), so that I can add this to all existing datamodules and forms with minimal effort only when needed.

Iterating all components and filtering by their type is easy, but for the components which already have event handlers assigned, I need a way to store the existing event handlers, and assign a new modified event handler which first does the logging and then will invoke the original code which was already present.

So this code

procedure TMyDatamodule.OnBeforeOpen(Sender: TDataset);
begin
  SomeProc;
end;

at run time would become

procedure TMyDatamodule.OnBeforeOpen(Sender: TDataset);
begin
  StoreStartTime(Sender); // injected code

  SomeProc;
end;

Is there a design pattern which can be applied, or even some example code which shows how to implement this in Delphi?

+1  A: 

There is no generic way to do this without going really really low level.
Basically you'd write something along the lines of the Delphi debugger.

For TDataSet:

I'd create a fresh TDataSource and point it to the TDataSet instance. Then I would use create a Data Aware component, and use the TDataLink to capture the things you are interested in.

From scratch, this is a couple of days work. But you can get a head start with the sample code for my conference session "Smarter code with Databases and data aware controls".
See my Conferences, seminars and other public appearances page at wiert.wordpress.com for the link.

--jeroen

Jeroen Pluimers
+2  A: 

If the function or procedure in the component you want to 'hook' is declard virtual or dynamic it can be done in the following manner:

Let's assume for arguments sake that you wantto see all AfterOpen's from TDataset. This event handler is called from the virtual method:

procedure TDataSet.DoAfterOpen;

Create a new unit UnitDatasetTester (typed it in manual)

unit UnitDatasetTester;

interface

uses
  DB;

type
  TDataset = class( DB.TDataset )
  protected
    procedure DoAfterOpen; override;
  end;

implementation

uses
  MySpecialLoggingUnit; 

procedure TDataset.DoAfterOpen;
begin
  inherited;
  SpecialLog.Add( 'Hello world' );
end;

If you do not use this unit all works without loggig. If you use this unit as the LASt unit in your uses list (at least AFTER the DB uses) you do have logging for all datasets in that unit.

Ritsaert Hornstra
Another method is copying the db unit and add the copy in your project directory (make sure it is in your project). Now edit this db.pas file to add the logging you want. Create e second project without this unit used and a different project diretory but using all other unit from the first project the same.
Ritsaert Hornstra
Nice tip, but I would make logging conditional (on build mode, a compilation switch or a variable) and always build the project with this unit. Adding and removing units on demand (and putting them in the right space) is too error-prone.
mghie
@mghie: you can do that by making the uses wrappied within a conditional. But that is not part of the question. Could have mentioned it though.
Ritsaert Hornstra
+2  A: 

I would try this:

TDataSetBeforeOpenStartTimeStorer = class(TObject)

constructor Create(MyDataModule : TMyDatamodule);
begin
    OldBeforeOpen := MyDatamodule.OnBeforeOpen;
    MyDatamodule.OnBeforeOpen = NewBeforeOpen;
end;

procedure NewBeforeOpen(Sender: TDataset);
begin
  StoreStartTime(Sender);
  if Assigned(OldBeforeOpen) then
    OldBeforeOpen(Sender);
end;

Attach one TDataSetBeforeOpenStartTimeStorer instance to every TDataSet and you'll have your functionality.

LukLed
+5  A: 

You can use the following scheme to rewire the datasets:

type
  TDataSetEventWrapper = class
  private
    FDataSet: TDataSet;
    FOrgAfterOpen: TDataSetNotifyEvent;
    FOrgBeforeOpen: TDataSetNotifyEvent;
    procedure MyAfterOpen(DataSet: TDataSet);
    procedure MyBeforeOpen(DataSet: TDataSet);
  protected
    property DataSet: TDataSet read FDataSet;
  public
    constructor Create(ADataSet: TDataSet);
    destructor Destroy; override;
  end;

constructor TDataSetEventWrapper.Create(ADataSet: TDataSet);
begin
  Assert(ADataSet <> nil);
  inherited Create;
  FDataSet := ADataSet;
  FOrgAfterOpen := FDataSet.AfterOpen;
  FOrgBeforeOpen := FDataSet.BeforeOpen;
  FDataSet.AfterOpen := MyAfterOpen;
  FDataSet.BeforeOpen := MyBeforeOpen;
end;

destructor TDataSetEventWrapper.Destroy;
begin
  FDataSet.AfterOpen := FOrgAfterOpen;
  FDataSet.BeforeOpen := FOrgBeforeOpen;
  inherited;
end;

procedure TDataSetEventWrapper.MyBeforeOpen(DataSet: TDataSet);
begin
  if Assigned(FOrgBeforeOpen) then
    FOrgBeforeOpen(DataSet);
end;

procedure TDataSetEventWrapper.MyAfterOpen(DataSet: TDataSet);
begin
  if Assigned(FOrgAfterOpen) then
    FOrgAfterOpen(DataSet);
end;

Inside MyAfterOpen and MyBeforeOpen you can bring in your code before, after or around the call to the original event handler.

Collect the wrapper objects in a TObjectList with OwnsObjects := true and everything will revert to the original when you clear or free the objectlist.

Caution: For this code to work the events have to be wired already when you create the wrappers and manually reassigning those events is forbidden.

Uwe Raabe
I've just seen that LukLed had a similar idea.
Uwe Raabe
@Uwe Raabe: +1 for nice description. I use this solution all the time to synchronize Insert/Edit/Post in datasets with 1-1 relation. Calling Insert/Edit/Post in one triggers Insert/Edit/Post in second. Works pretty well.
LukLed
Advantage: you don't need unit ticks with abiguous names. Disadvantage: more intrusive: you need to add code to your project to hook the events even when using a separate class.
Ritsaert Hornstra
@Ritsaert: the additional code would require only one line in the dpr, something like `AddDataSetLoggers([DataModule1, DataModule2, ...]);`
mjustin
@mjustin: I did not see the single line routine, but you're right it should be easy to add that. Note that this does not give you the hookups automatically when you create dataset dynamically (I tend to do that quite often).
Ritsaert Hornstra
@Uwe: please put even more emphasis on the drawback: this scheme only works when nobody changes the event contents, and the events are hooked up at the start. On the other hand: it is the only way to do it in a non-DataSet environment. For a DataSet environment it is much more robust to use the TDataLink scheme I mentioned.
Jeroen Pluimers
@Jeroen: I know, but the OP stated: "for the components which already have event handlers assigned, I need a way to store the existing event handlers, and assign a new modified event handler which first does the logging and then will invoke the original code which was already present." My code does exactly that.
Uwe Raabe
@Uwe: Thanks for marking the emphasis in your answer.
Jeroen Pluimers
A: 

If you want to do it in a general purpose (and "quick and easy") way, you could use detouring and RTTI (RTTI: search for published event properties; detouring: hook original function and reroute/detour it to your own function).

I use detouring in my open source Delphi profiler: http://code.google.com/p/asmprofiler/
(in my general profile function I use assembly to preserve the stack, cpu registers, etc so it can profile/hook any function).

But if you want a more "intelligent" way (like knowledge about beforeopen and afteropen) you have to do some additional work: you need to make a special handling class for TDataset descendants etc.

André