Using foreach loop.

Question

I break the code of the for loop without using break like I have for loop given below.And when i is 1 or 2 or 3 or any else but if condition is true then loop will be terminated because i will be 5 if the condition is true.And so NO need of break is needed there.Beacause I do not want to use break.I have done like this here.It works.

int myCondition=0;
bool flag=false;
for(int i=0;i<5;i++)
{
   if(myCondition==0)
   {
       flag=true;
   }
   if(flag)
       i=5;
}

But now I want to use foreach loop and in this loop when some condition is true then I want to break the foreach loop code.So what should I do here for breaking the foreach loop code without using break ? Like in the above for loop I have initialize i to 5 when condition is true.In the foreach loop anything like that to do to avoid break.

Answer 1

This is probably going to get me downvoted... but you should use the break keyword.

Failing that:

foreach(var foo in bar)
{
  if(condition)
  {
    //perform normal loop code
    //set condition if required.
  }
  //otherwise do nothing - the loop will iterate all the way to the end without 
  //doing anything.
}

You could be more expressive and use if(condition){ /*blah*/}else { continue; } inside the loop - but either way it does the same thing.

You can't do much else to break out of a for each other than:

• Use break
• Throw an Exception

Answer 2

Not using break in your for(;;) loop is a serious stylistic mistake. But you'll get away with it. But not when you use foreach, you have to use the break keyword.

Pay attention to the title of this blog post.

Answer 3

In general, the 'pattern' you describe here is a code smell. It is NOT a good idea to change the index variable in a for-loop. It can result in unreadable, hard-to-maintain code, especially if the loop grows large.

That being said, why would you not want to use the break keyword. It is meant for this purpose, and whatever downside it has (in your opinion) is still a far better solution than the one you describe here.

Last, I see no way to do the same thing using a foreach loop in a sensible way.

Answer 4

You should use what's in the language. There's no need to avoid break - just use it. Or to put it another way, "I don't want to use break" is not a good enough justification: if you think you've got a really good reason not to use it, then you should explain that reason. Don't hobble yourself by pretending perfectly reasonable features don't exist, and coming up with convoluted schemes to avoid them.

Answer 5

Don't do it.

Your manipulation of 'i' in the for loop is questionable already. Trying to mess with the iterator in a foreach-loop would be downright dirty. If it compiles at all.

I would write your example with a break or as:

bool myCondition=false;
for(int i=0;i<5 && !myCondition;i++)
{
   ....
}

In a foreach loop, when you're done before the entire sequence is complete, just call break

Answer 6

Well, thats why there is this comand "break". I have no reasons why shouldnt you use it.

Answer 7

Your code should absolutely be:

bool myCondition = false;

for(int i=0;i<5;i++)
{
   // do stuff
   if(myCondition)
      break;
}

Not only are you using the commands (i.e. tools) provided by the language, but you are keeping the code very readable, and maintainable. The break command is fundamental to the language.

Trying to come up with some reason not to use break is like doing math on a calculator -- literally, turn the calculator over, get a silver paint marker, and do some math. You are crippling yourself by not using the tools in front of you.