tags:

views:

356

answers:

4

I have 2 objects, both of which I want to convert to dictionarys. I use toDictionary<>().

The lambda expression for one object to get the key is (i => i.name). For the other, it's (i => i.inner.name). In the second one, i.name doesn't exist. i.inner.name ALWAYS exists if i.name doesn't.

Is there a lambda expression I can use to combine these two? Basically to read as:

"if i.name exists then set id to i.name, else set id to i.inner.name".

Many thanks.

Update

When I say "don't exist", I mean the objects don't actually have the properties, not that the properties are just null.

A: 

Yes, the conditional operator ("ternary operator") does what you want:

(i => i.name != null ? i.name : i.inner.name)

Assuming, of course, that you can detect the "existence" of the name by checking for null.

Edit: In that case, Kirschstein's answer is better, of course.

Thomas
What I meant is, i.name doesn't exist at all. The property name isn't there. I can't use null.Apologies if I made that unclear.
AndyC
A: 

something along the lines of

collection1.ForEach(i => myDictionary.Add((i.name.length == 0 ? i.inner.name : i.name),value);

(untested) should do the trick if i.name is not null (an empty string), or

collection1.ForEach(i => myDictionary.Add((i.name ?? i.inner.name),value);

(also untested)

ZombieSheep
+6  A: 

If these are two distinct (reference) types then you can test them using the is or as keywords:

i => {
         var x = i as TypeThatHasNameProperty;
         return (x != null) ? x.name : i.inner.name;
     }

If you can't test for specific types then you can use reflection to test for the name property itself:

i => {
         var pi = i.GetType().GetProperty("name");
         return (pi != null) ? pi.GetValue(i, null) : i.inner.name;
     }
LukeH
Don't you need to cast `i` to `TypeThatHasNameProperty` before you can access the `Name` property?
dtb
@dtb: Probably, I suppose it depends on what the rest of the OP's code looks like. (But it wouldn't do any harm to make the cast anyway, although in my example code I think using `as` is probably more appropriate than a plain cast.)
LukeH
+2  A: 

Why don't you give each object a ToDictionary method of their own, as they obviously have their own behaviours in this case.

If you can't add to the objects, because you don't own them, you can always write extension methods for them.

Any reason your trying to force feed them into one "common" function?

Sekhat
Maybe overriding ToString() would be the best behavioural choice for these objects. Of course, that depends on whether you rely on other behaviour in ToString() elsewhere...
ZombieSheep
@Sekhat I was just seeing if I could combine it into one function as I need to do it quite a few times. For the sake of tidiness.
AndyC