views:

91

answers:

2

My code is like

var shapes1 = [  r.image("node.gif",190, 100, 47, 45)];
var shapes2 =[];
for (var i = 0, ii = shapes1.length; i < ii; i++) {
    shapes1[i].mousedown(function(e){
        var temp=this.clone();
        shapes1.push(temp);
        //now I want to remove "this" from shapes1
        //and put it into shape2
        //HOW??
        isDrag=true;
        e.preventDefault();
    });
}

Maybe this is the wrong way to do it? I should be using a class instead, but isn't that for DOM items?

+1  A: 

Use splice(index, range) to remove items from an array.

AndyC
+1  A: 

I find it handy to have things like

function removeIf(arr, predicate) {

    for (var i = 0; i < arr.length; i++) {
        if (predicate(arr[i])) {
            arr.splice(i--, 1);
        }
    }
}

So then:

var shapes1 = [  r.image("node.gif",190, 100, 47, 45)];
var shapes2 =[];
for (var i = 0, ii = shapes1.length; i < ii; i++) {
    shapes1[i].mousedown(function(e){
        var temp=this.clone();
        shapes1.push(temp);

        removeIf(shapes1, function (item) { return item === this; });

        shapes2.push(this);

        isDrag=true;
        e.preventDefault();
    });
}
Daniel Earwicker
@Daniel, thanks for the function...
TiansHUo
No problem. The nice thing about passing in a function to test each item is that you can use it to delete multiple items based on any "query" you want, e.g. instead of `item === this` it could be `item.firstName.length > item.lastName.length` to delete any item with `firstName` longer than `lastName` (okay, that's just a silly example, but you see how powerful it is).
Daniel Earwicker