Being a C++ developer myself I have spend great time with the C++ Builder (BCB), it is an excellent tool for rapid application development. The VCL framework has its obvious advantages, and provides a C++ developer with an excellent tool for building applications rapidly. Obviously a lot of things has happened over the last couple of years, and the competing frameworks have grown way more mature, wxWidgets and Qt to mention two are both providing a lot of what VCL provides, but does so while maintaining compiler independence.
I find this is extremely important for a few reasons:
Firstly the Borland/Codegear/Embarcardero C++ compiler lacks a lot of the more modern features of many competing compilers. It is not as standard compliant as many other compilers, I can't count the number of problems I used to have compiling the boost libraries in BCB, although they seem to have fixed many of those problems.
Secondly I must admit that I have a shed of doubt concerning the Embarcardero commitment to the BCB product. It is my personal belief that the BCB product is only used by a very marginal audience, and isn't bringing in enough money to keep the product properly maintained, at least compared to its Delphi relative. I fear the BCB product will cease to exist within the next 3-4 years. I must emphasize though that this is my own personal fear, and only based on guesses.
The first two combined provides a worst case scenario where you are stuck with a framework where switching compiler can turn out to be impossible. The Delphi compiler however I believe will be around for much longer, given the (guessed) larger userbase, the performance of the compiled code will be close to that of the BCB but with a larger userbase the amount of support to get, will be larger, and easier to find.
Having said all that, I still like the BCB, and as mentioned by Stephane it really boils down to what you need. Since you are determined to use the VCL it will probably not be important to find a more cross compiler based framework, or perhaps you have already done those considerations.
If you like the C++ language then I'd use the BCB, if you like a language with a larger userbase, and where support is easier to find in that language I'd choose Delphi. But then again, most likely you will have bought the RAD Studio and have both compilers, then why limit your self to one language? If you already know one language switching to another language should be quite easy. Especially when the language you know is C++, and in particular when you have worked with Delphi before as well.
I like to say that you have to choose the right tool for the right job. Therefore perhaps the question shouldn't be what tool should I use, but what tool fits this particular job, if you are planning on writing high performance code utilizing lots of multithreading preferably optimized for multicore architectures, then most likely it will be neither BCB nor Delphi that you will be looking for. If you are looking for cross platform development, and you don't like the idea of Java, then perhaps the Pascal language in the shape of the Freepascal/Lazarus combination will be your best bet.
If you want to develop applications rapidly, like to utilize databases, want to have a fancy GUI window and don't really mind some code overhead, then I guess your bet on the VCL framework might be the best choice for you, and to be honest all things considered, it doesn't really matter whether it is BCB or Delphi you use in that case.
So if all other considerations boils down to a few choices where they are technically even candidates, choose the one you like the most, and feel you are most productive in.