ansaurus

Question

Sticky/static variable references in for loops

Answer 1

A:

You need to attach any data on the elements or on http://api.jquery.com/jQuery.data/ in order to reuse later on.

e.g

...
var li = $('<li>' + nr + '</li>');
jQuery.data(li, "the-value", foo);
li.click(function() {
    var foo = jQuery.data(li, "the-value");
    ...
}

cherouvim 2010-04-03 09:30:43

Yes, this solved the problem! The jQuery docs points out that you should use li.data instead http://api.jquery.com/data/. I've added the solution to the question. Thanks!

pthulin 2010-04-03 10:03:03

Answer 2

A:

This is working as it should, you are asking the click event to use these variables (not absolute values) and by the time the method is called the variables are at their 'max' values.

Try using the title attribute to store the value you want to return, i.e.:

var li = $('<li title="' + nr + '">' + nr + '</li>');

Then your alert would be:

alert(this.attr('title'));

Not tested but that should work or at least set you on the right track.

Lazarus 2010-04-03 09:35:43

Thanks for the tip, but in my real use case I have a pretty large JSON structure that I want to associate with each button. I've edited the question to show how I solved it.

pthulin 2010-04-03 10:05:03

Answer 3

+1 A:

Alternately, place a closure inside the for loop.

        $(document).ready(function() {
            var numbers = ['one', 'two', 'three'];
            for (i in numbers) {
                (function () {
                var nr = numbers[i];
                var li = $('<li>' + nr + '</li>');

                li.click(function() {
                    var newVariable = String(nr);
                    alert(i); // 2
                    alert(nr); // three
                    alert(newVariable); // three
                    alert(li.html()); // three
                });

                $('ul').append(li);

                }());
            }
        });

It's also bad practise for using for in for iterating over an array. It should be strictly used for iterating over object fields. Use the for(;;;) instead.

Matt 2010-04-03 09:52:03

ansaurus

tags:

views:

answers:

Sticky/static variable references in for loops

Edit:

related questions