views:

48

answers:

2

In Drupal you can create your own nodetype in a custom module. Doing this you get to create your own form which is all very nice.

However if you want to add js the form things get a bit more tricky. If you add the js in the form, the js will only be added form the form when it is loaded. If the user would post the form with validation errors, the form function is not run again and thus the js is not added. Normally you would just create a menu callback and add the js there, but for the node add form, this wont be a possible solution.

So what is the best solution for adding js in a node add form, to keep it persistant when the form doesn't validate?

+1  A: 

I posted a patch to the Smilies module that fixes this problem: Smilies are not selectable when resubmitting a page

The patch adds a hook_nodeapi() function to check if the node operation is "verify" and if it is, it checks if the node is supposed to have smileys and if so calls the function to add the smileys.js javascript file that creates the selection form.

You should just need to do the same in your case. This will require you write a very simple module that implements the hook_nodeapi function and checks for updates in the same way the patched Smileys module does.

alxp
Thanx for the tip. I ended up using a theme function to do the trick since it's a bit more clean in this specific case.
googletorp
+1  A: 

Trying some different hacks, I found a quite simple solution to this problem, create a theme function for the form and add the js there. That would look something like this:

function theme_content_type_node_form($form) {
  drupal_add_js(...);
  return theme('node_form', $form);
}

This just calls the default theme function for the node add form after adding the js. As the theme function is called even the form is cached, this works nicely. You also need to implement hook_theme to make this work.

googletorp
Interesting - I'm surprised that this works without creating an infinite loop, as the call to `theme('node_form')` might end up invoking your override again. Wouldn't it be better to put the `drupal_add_js` call in a `theme_preprocess` function?
Henrik Opel
@Henrik Opel : I guess a theme_preprocess function would do the trick aswell, I didn't think of it at the time. The theme_node_form function is the function that would be called if the content_type_node_form doesn't exist, so I don't think an infinite loop is of any danger. But I guess it is a bit more hackish than just using s theme preprocess function.
googletorp