ansaurus

Question

Why won't this Schema validate this XML file?

Answer 1

A:

For a start:

         <Semestre>Verano<Semestre>

...doesn't look well-formed.

fd 2010-04-12 15:49:31

@fd: I've just fixed the input in what was hopefully the intent of the OP.

Tomalak 2010-04-12 16:42:10

Yes, I was a bit rushed, but spotted that error which could be easy to miss. Just trying to get the ball rolling. Your answer is excellent. +1

fd 2010-04-12 21:19:44

Answer 2

+1 A:

Try declaring and using your types separately. This makes the XSD a bit longer, but less nested and more readable (and more reusable, too):

<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"&gt;

  <!-- document element -->
  <xs:element name="Lista" type="listaType" />

  <!-- type definitions -->
  <xs:complexType name="listaType">
    <xs:sequence>
      <xs:element name="Pelicula" type="peliculaType" minOccurs="0" maxOccurs="unbounded" />
    </xs:sequence>
    <xs:attribute name="count" type="countType" />
  </xs:complexType>

  <xs:complexType name="peliculaType">
    <xs:all>
      <xs:element name="Genero" type="generoType" />
      <xs:element name="Director" type="directorType" />
      <xs:element name="Temporada" type="temporadaType" />
    </xs:all>
    <xs:attribute name="nombre" type="xs:string" />
  </xs:complexType>

  <xs:complexType name="directorType">
    <xs:simpleContent>
      <xs:extension base="xs:string">
        <xs:attribute name="sexo" type="sexoType" />
      </xs:extension>
    </xs:simpleContent> 
  </xs:complexType>

  <xs:complexType name="temporadaType">
    <xs:all>
      <xs:element name="Anho" type="anhoType" />
      <xs:element name="Semestre" type="semestreType" />
    </xs:all>
  </xs:complexType>

  <xs:simpleType name="sexoType">
    <xs:restriction base="xs:string"> 
      <xs:enumeration value="F" /> 
      <xs:enumeration value="M" /> 
    </xs:restriction> 
  </xs:simpleType>

  <xs:simpleType name="generoType"> 
    <xs:restriction base="xs:string"> 
      <xs:enumeration value="Drama" /> 
      <xs:enumeration value="Accion" /> 
      <xs:enumeration value="Romance" /> 
      <xs:enumeration value="Ficcion" /> 
    </xs:restriction> 
  </xs:simpleType>

  <xs:simpleType name="semestreType"> 
    <xs:restriction base="xs:string"> 
      <xs:enumeration value="Verano" /> 
      <xs:enumeration value="Invierno" /> 
    </xs:restriction> 
  </xs:simpleType>

  <xs:simpleType name="anhoType">
    <xs:restriction base="xs:integer"> 
      <xs:minInclusive value="1970" /> 
      <xs:maxInclusive value="2020" /> 
    </xs:restriction>
  </xs:simpleType>

  <xs:simpleType name="countType">
    <xs:restriction base="xs:integer">
      <xs:minInclusive value="0" />
    </xs:restriction>
  </xs:simpleType>

</xs:schema>

The above validates your input XML.

Note that:

The convention for the XML Schema namespace prefix is xs (AFAIK - you can still go on and use xsd if you prefer).
The count attribute is really unnecessary, since the count can a) easily be calculated and b) there is a risk of something going wrong when the count attribute value and the actual count differ for some reason. Things that are derivable from the data should never be part of the data.

Oh, and to answer your initial question (why does mine not work):

You never declare an actual document element ("Lista"), you just declare its type. Compare with my solution.
In the complexType name="Lista":
- attribute cannot be the first child of a complex type. Attributes must be declared after everything else.
- complexContent cannot contain element.
- in fact, you don't need a complexContent at all - just use a sequence instead.
In element name="Pelicula":
- The type attribute is illegal when you declare a complexType within.
In the complexType for "Pelicula":
- Again, attributes last.
- Don't use a sequence unless you want to make any other order of children illegal. In this type of document I would guess child order is irrelevant.
In element name="Director":
- You can't declare any attributes since when you already declared a type. Include the sexo attribute in the directorType
In simpleType name="directorType":
- This should in reality be a complexType containing simpleContent with an extension. This way you can include the sexo attribute
Your XSD isn't even well formed XML.
Your XML iswas not well-formed, either. I have fixed it to be able to test in the first place.

P.S.: There is enough XSD documentation freely available to fix many of the basic problems you've had. There are XSD validators on the Net that help you by telling you what constructs are illegal. Knowing everything is absolutely not necessary, but a little reading + trial and error would have helped. ;-)

Tomalak 2010-04-12 16:35:50

Great suggestions; thank your very much for your time.

Serg 2010-04-12 17:25:56

@Sergio: You are welcome. ;-) P.S.: I hope you didn't take the critique too personally. Thinking about it, I'm going to remove it. I guess I've made my point. ;-)

Tomalak 2010-04-12 17:36:21

No please don't. One only learns from people who are better than you. I can only hope that everyone that answers my questions critique me like you have.

Serg 2010-04-12 18:54:18

ansaurus

tags:

views:

answers:

Why won't this Schema validate this XML file?

related questions