tags:

views:

21

answers:

2

This code does not function as expected:

// $field contains the name of a subclass of WMSInput.
$fieldClone = clone $field;

echo $fieldClone->getInputName();

// Method on abstract WMSInput superclass.
$fieldClone->setInputName( 'name' );

echo $fieldClone->getInputName();

The WMSInput class:

abstract class WMSInput {
  private $inputName;

  public function setInputName( $inputName ) {
    $this->inputName = $inputName;
  }
}

There are no PHP errors (error reporting is set to E_ALL).

Actual Results

email
email

Expected Results

email
name

Any ideas?

+2  A: 

On my test site it worked ok.

You haven't copied method getInputName in your example. I'd start searching in there. Maybe you return not the desired variable?

My test code was:

<?php

abstract class WMSInput {
  private $inputName;

  public function setInputName( $inputName ) {
    $this->inputName = $inputName;
  }

  public function getInputName() {
    return $this->inputName;
  }
}

class Test extends WMSInput {
}

$field = new Test();

$field->setInputName('email');

// $field contains the name of a subclass of WMSInput.
$fieldClone = clone $field;

echo $fieldClone->getInputName();

// Method on abstract WMSInput superclass.
$fieldClone->setInputName( 'name' );

echo $fieldClone->getInputName();

Output:

emailname

which is correct.

Tomasz Struczyński
A: 

echo debuging a little :)

  1. in set InputName echo the $inputName before the assign
  2. in set InputName echo the $this->inputName before the assign
  3. in set InputName echo the $this->inputName after the assign

also try setting the inputName property to protected, if you have that class as abstract then in the parent classes you would not have access to that method

solomongaby
But he uses public methods (accessors) to get/set this property. This is correct.
Tomasz Struczyński
I added a lot of echo statements for debugging. When inside the `setInputName` method, the `inputName` variable is set correctly. The value reverts immediately after leaving the method. Puzzling.
Dave Jarvis