ansaurus

Question

Answer 1

+1 A:

A good and common practice is to use Db objects (DbConnection, DbCommand, readers, adapters, etc.) in Using blocks.

This will prevent 99% of this type of thing from ever happening, by ensuring the objects are always disposed when you are done using them.

Tom Tresansky 2010-04-20 17:33:56

Answer 2

A:

Such errors are not because of wrong disposing - The connection was NOT closed.

Such error can be then you use SqlConnection in the static class or method which holds open connection, and after that - in not-static, and in this moment exception can occur.

Update: Well, this method is not very save - it do exactly that I was talking about - he creates connection, but never releases it. SqlConnection is very heavy object, and you should dispose it right after you get or set your data.

You should rewrite your logic - create one connection per page or per operation, and you should never store the connection in your classes.

If this is impossible for you, use the lock statement for ensure singleton, like this:

private static object singleton;

lock (singleton)
{
    // Some manipulations with your server
}

VMAtm 2010-04-20 17:50:09

I've updated my answer, please review it

VMAtm 2010-04-21 08:21:25

So you mean when all server operations has finished and the result has been returned to the users browser, the db connection is not released automatically?If so is there a method which automatically is called so I can release the connection when all server activity has finished?

jweber 2010-04-24 09:27:02

1. You can use the .Close() or .Dispose() methods of the SqlConnection2. You can use the using statement: using (SqlConnection conn = new SqlConnection(DB_CONNECTION_STRING)) { // some code goes here }After all code from the using block is done, SqlConnection will be disposed automatically.

VMAtm 2010-04-27 11:12:42

By using the "using(..){..}" I think my problems is solved. I haven't registreted any errors the last two days compared to about 20 per day before.Thank you very much.

jweber 2010-04-30 10:08:56

Good luck in your projects

VMAtm 2010-04-30 18:58:18

Answer 3

A:

VMAtm: Maybe you got something there, because the exception is showing a lot more after the site is getting more and more users. I have a static class to hold the database connection using a singleton method...

public static SqlConnection getDbConnection() 
{ 
    if (sqlConn == null) 
    { 
        source = "data source=..."; 
        sqlConn = new SqlConnection(source); 
    }
    return sqlConn; 
}

Is this method completely save?

All database calls are called in abstract classes using static methods and these abstract classes are getting the db connection from the singleton method

jweber 2010-04-20 18:52:03

ansaurus

tags:

views:

answers:

HttpUnhandledException ASP.NET

related questions