views:

172

answers:

4

Why can't I do like this?

[Required(ErrorMessage = "*")]
[RegularExpression("^[a-zA-Z0-9_]*$", ErrorMessage = Resources.RegistrationModel.UsernameError)]
public string Username { get; set; }

What is the error message telling me?

An attribute argument must be a constant expression , typeof expression or array creation expression of an attribute parameter type.

A: 

It means that you cannot determine the value of the argument you are passing into the attribute at runtime, it must be at compile time so the value is embedded into the assembly.

The error message value needs to be a constant expression.

For information, attribute arguments can only be of types bool, byte, char, short, int, long, float, double, string, System.Type, and enums.

David Neale
Does not really solve the problem in the OP.
Obalix
A: 

You should instead look at the ErrorMessageResourceName and ErrorMessageResourceType properties of this attribute. They do allow the error message to be pulled from a resource.

Damien_The_Unbeliever
What would the ResourceType be if fetched from the App_GlobalResources folder?
Jova
Resources.RegistrationModel, at a guess?
Damien_The_Unbeliever
@Jova: see edit in my post.
Obalix
+2  A: 

When you are using the ErrorMessage property only constant strings or string literal can be assigned to it.

Use the ErrorMessageResourceType and ErrorMessageResourceName instead to specity your resources.

[RegularExpression(
    "^[a-zA-Z0-9_]*$", 
    ErrorMessageResourceType=typeof(Resources.RegistrationModel),
    ErrorMessageResourceName= "UsernameError"
)]

Note that the resources must be public (can be set in the resource editor).

Setting resource access to public

Obalix
Thank you Obalix.
Jova
What if the resource is in App_GlobalResources? You can't change the Access Modifier for globalresources. Would you be forced to move those resources elsewhere in order for them to work with DataAnnotations?
Jova
A: 

Try FluentModelMetaDataProvider.

Managed to use resources for error messages in strongly typed fashion.

Looks like this:

using System.Web.Mvc.Extensibility;

namespace UI.Model
{
    public class StoreInputMetadata : ModelMetadataConfigurationBase<StoreInput>
    {
        public StoreInputMetadata()
        {
            Configure(m => m.Id)
                .Hide();
            Configure(model => model.Name)
                .Required(Resources.Whatever.StoreIsRequired)
                .MaximumLength(64, Resources.Whatever.StoreNameLengthSomething);
        }
    }
}

What is the error message telling me?

An attribute argument must be a constant expression, typeof expression or array creation expression of an attribute parameter type.

It's already self explanatory. C# isn't dynamic language like Ruby where You can write classes that inherits random base class at runtime. :)

Here's what Skeet says about this.

Arnis L.