How to use setAttribute in javascript

Question

Is this the correct format?

var title = new_element.setAttribute('jcarouselindex', "'items+1'");
alert(title);

Answer 1

No need to put the second parameter in quotes.

var title = new_element.setAttribute('jcarouselindex', items+1);

If you want to set a custom attribute then you can use HTML5 data-attributes, something like

var title = new_element.setAttribute('data-jcarouselindex', items+1);

Answer 2

It is syntactically correct JS/DOM, but there is no 'jcarouselindex' attribute in HTML and using setAttribute (as opposed to setting properties that map to attributes) is generally bad practice as it is buggy in MSIE (although not in such a way that will cause a problem in this case).

You might not be intending to have <foo jcarouselindex="&#39;items+1&#39;"> as your end result though.

Answer 3

Using jQuery?

var title = $('#new_element').attr('jcarouselindex', "'items+1'"); alert(title);

Answer 4

You have too many quotes:

var index = items + 1;
new_element.setAttribute('jcarouselindex', index);

Remark: there's no jcarouselindex attribute defined in HTML elements so this is not very clean code.