ansaurus

Question

Variable is Undefined

Answer 1

+1 A:

Try this:

var bod = document.body;

I don't know why bod comes back as undefined in your code.. it works for me in Chrome. What browser are you running?

Also, are you sure it's bod that's undefined? Not setBgcolor or something else?

EDIT:

Change this line of code:

window.onload = lbp.init();

To this:

window.onload = lbp.init;

You're currently assigning the result of lpd.init() to onload.. you need to just assign the reference.

Matt 2010-04-26 19:51:38

Added full page code. Running in firefox.

Matrym 2010-04-26 19:56:32

@Martym See my edit

Matt 2010-04-26 19:58:15

Thanks Matt - right on the money.

Matrym 2010-04-26 20:01:33

Answer 2

+2 A:

Change it to

window.onload = lbp.init;

When you write window.onload = lbp.init(), you are calling the init function, and assigning whatever it returns to window.onload.
Therefore, the function is being called immediately (before the window is loaded), and you're assigning undefined to window.onload. (Because init doesn't return anything)

You need to assign the init function itself to onload without calling it.

SLaks 2010-04-26 19:58:17

Thanks, you're right slaks :)

Matrym 2010-04-26 20:01:58

Answer 3

+2 A:

Your code needs a few teaks, here's an overall fix:

var lbp = {
    defaults: {
        color: "blue"
    },
    init: function(config) {
        if(config) {
            for(prop in config){
                lbp.defaults[prop] = config[prop];
            }
        }
        var bod = document.body;
        bod.style.backgroundColor = lbp.defaults.color;
    }
}
window.onload = lbp.init;

Previous it was calling init instantly because window.onload = lbp.init() was assigning the result of lbp.init to the onload function, not assigning the actual function, this is fixed above.

Also, not sure where setBgcolor comes from in your code, I believe you meant lbp here, it works in the same code above, give it a test.

Nick Craver 2010-04-26 20:01:25

Yeah, I realized those other config calls too after body was working. Thanks!

Matrym 2010-04-26 20:03:14

Nick - if I don't use parens in window.onload = lbp.init, how am I supposed to pas in config, which would override the default configurations?

Matrym 2010-04-26 20:33:30

@Matrym - You can use an anonymous function, like this: `window.onload = function() { lbp.init({ optionsHere }); };`

Nick Craver 2010-04-26 20:50:50

ansaurus

tags:

views:

answers:

Variable is Undefined

related questions