views:

309

answers:

3

I have written code to TryParse enum either by value or by its name as shown below. How can I extend this code to include parsing enums with Flags attribute?

    public static bool TryParse<T>(this T enum_type, object value, out T result) 
                where T : struct
            {
                return enum_type.TryParse<T>(value, true, out result);
            }



 public static bool TryParse<T>(this T enum_type, 
object value, bool ignoreCase, out T result)
        where T : struct
    {
        result = default(T);
        var is_converted = false;

        var is_valid_value_for_conversion = new Func<T, object, bool, bool>[]{
            (e, v, i) => e.GetType().IsEnum,
            (e, v, i) => v != null,
            (e, v, i) => Enum.GetNames(e.GetType()).Any(n => String.Compare(n, v.ToString(), i) == 0) || Enum.IsDefined(e.GetType(), v)
        };

        if(is_valid_value_for_conversion.All(rule => rule(enum_type, value, ignoreCase))){
            result = (T)Enum.Parse(typeof(T), value.ToString(), ignoreCase);
            is_converted = true;
        }

        return is_converted;
    }

Currently this code works for the following enums:

enum SomeEnum{ A, B, C } 
// can parse either by 'A' or 'a'

enum SomeEnum1 : int { A = 1, B = 2, C = 3 } 
// can parse either by 'A' or 'a' or 1 or "1"

Does not work for:

[Flags]
enum SomeEnum2 { A = 1, B = 2, C = 4 } // can parse either by 'A' or 'a'
// cannot parse for A|B

Thanks!

+2  A: 

As of .NET 4, there is a Enum.TryParse<T> method. It supports Flags enumerations out of the box:

string x = (SomeEnum2.A | SomeEnum2.B).ToString();  //  x == "A, B"
SomeEnum2 y;
bool success = Enum.TryParse<SomeEnum2>(x, out y);  //  y == A|B
dtb
yes TryParse is exposed in 4.0, I was looking for a solution in 3.5...
Sunny
+3  A: 

Flags enums are written using , by using the .Net convention and not |. Enum.Parse() works perfectly when using ',' strings:

[Flags]
public enum Flags
{
    A = 1,
    B = 2,
    C = 4,
    D = 8,
}

var enumString =  (Flags.A | Flags.B | Flags.C).ToString();
Console.WriteLine(enumString); // Outputs: A, B, C
Flags f = (Flags)Enum.Parse(typeof(Flags),  enumString);
Console.WriteLine(f); // Outputs: A, B, C
Pop Catalin
A: 

@Pop's answer gave me a clue & I modified the rules check in my code to look like:

var is_valid_value_for_conversion = new Func<T, object, bool, bool>[]
{
    (e, v, i) => e.GetType().IsEnum,
    (e, v, i) => value != null,
    (e, v, i) => Enum.GetNames(e.GetType()).Any(
                n => String.Compare(n, v.ToString(), i) == 0 
                || (v.ToString().Contains(",") && v.ToString().ToLower().Contains(n.ToLower()))) 
                || Enum.IsDefined(e.GetType(), v)
};

the rest remaining the same and it works for me

HTH someone else

Sunny
Shouldn't the null check be your first rule?
ChaosPandion
First check or second would not make a difference in this case IMO, unless I am missing something, besides because the constraint is on struct, I think we need to check if the call is on a valid enum type before checking if the value is null
Sunny