tags:

views:

333

answers:

5

If I have the enum type:

Public enum Sport
{
    Tennis = 0;
    Football = 1;
    Squash = 2;
    Volleyball = 3;
}

Can I somehow add during run-time:

PingPong = 4
+5  A: 

No, you cannot modify types at runtime. You could emit new types, but modifying existing ones is not possible.

Darin Dimitrov
Can an emitted new type replace an existing one?
Craig Johnston
No, it can't as this would mean that you would be able to modify existing types at runtime which you can't.
Darin Dimitrov
+4  A: 

The enum has a backing store, defaulting to int if you don't specify it. It is possible to directly assign values outside of the defined values:

Sport pingPong = (Sport)4;

Then you can check for it:

if (value == (Sport)4) {}

That is why you have the static function Enum.IsDefined() for checking if the actual value falls inside the expected values. Note that the function doesn't work for compound flag values.

bool isValueDefined = Enum.IsDefined(typeof(Sport), value);

EDIT: After Hans Passant's comment: You don't have to use the literal value 4. You could use anything which returns an int. For example:

Dictionary<int, string> AdditionalSports = new Dictionary<int, string>();
AdditionalSports.Add(4, "PingPong");

// Usages: if
if (AdditionalSports.ContainsKey(value))
{
    // Maybe do something with AdditionalSports[value], i.e. "PingPong"
}

// In a switch:
switch (value)
{
case default:
    // Since it won't be found in the enum-defined values
    if (AdditionalSports.ContainsKey(value))
    {
        // Maybe do something with AdditionalSports[value], i.e. "PingPong"
    }
}
Daniel Rose
I don't see how that it is at run-time because "PingPong" is being declared in the source.
Craig Johnston
It is not, the literal 4 can also be a variable. This is the best you can get.
Hans Passant
What would be the output of Console.WriteLine("My sport is: " + pingpong); ?
Craig Johnston
The runtime implicitely calls ToString() on pingpong. If pingpong had a defined enum value (ex. Sport.Tennis), the result is the enum value as text (i.e. "My sport is: Tennis"). If pingpong is not defined (ex. 4), it is the int value itself (i.e. "My sport is: 4"). You could use the AdditionalSports dictionary, i.e. Console.WriteLine("My sport is: " + AdditionalSports[pingpong]); to get "My sport is: PingPong".
Daniel Rose
+4  A: 

Here is more Object orientated way to maybe achieve what you are trying to achieve. This solution is inspired by early Java approach to enumeration:

struct Sport {
    readonly int value;
    public Sport(int value) {
        this.value = value;
    }
    public static implicit operator int(Sport sport) {
        return sport.value;
    }
    public static implicit operator Sport(int sport) {
        return new Sport(sport);
    }

    public const int Tennis =       0;
    public const int Football =     1;
    public const int Squash =       2;
    public const int Volleyball =   3;
}

//Usage:
Sport sport = Sport.Volleyball;
switch(sport) {
    case Sport.Squash:
        Console.WriteLine("I bounce really high");
        break;
}
Sport rugby = 5;
if (sport == rugby)
    Console.WriteLine("I am really big and eat a lot");

To walk through different featues of this solution.

  1. It's an immutable struct that wraps up an integer value. The value is enforced immutable by readonly keyword.

  2. The only way to create one of these structs is to call the constructor that takes the value as a parameter.

  3. implicit operator int is there so that the structure can be used in the switch bock - i.e. to make the structure convertible to int.

  4. implicit operator Sport is there so that you can assign integer values to the structure i.e. Sport rugby = 5.

  5. const values are the sports known at compile time. They can also be used as case labels.

What I would actually do

public static class Sports {
    public static readonly Sport Football = new Sport("Football");
    public static readonly Sport Tennis = new Sport("Tennis");
}

public class Sport {
    public Sport(string name) {
        Name = name;
    }
    public string Name { get; private set; }

    // override object.Equals
    public override bool Equals(object obj) {
        var other = obj as Sport;
        if(other == null) {
            return false;
        }

        return other == this;
    }

    // override object.GetHashCode
    public override int GetHashCode() {
        return Name.GetHashCode();
    }

    public static bool operator == (Sport sport1, Sport sport2) {
        if(Object.ReferenceEquals(sport1, null) && Object.ReferenceEquals(sport2 , null))
            return true;

        if(Object.ReferenceEquals(sport1, null) || Object.ReferenceEquals(sport2, null))
            return false;

        return sport1.Name == sport2.Name;
    }
    public static bool operator !=(Sport sport1, Sport sport2) {
        return !(sport1 == sport2);
    }
}

This would create a value class Sport that has a name. Depending on your application you can extend this class to provide other attributes and methods. Having this as class gives you more flexibility as you can subclass it.

Sports class provides a static collection of sports that are known at compile time. This is similar to how some .NET frameworks handle named colors (i.e. WPF). Here is the usage:

List<Sport> sports = new List<Sport>();

sports.Add(Sports.Football);
sports.Add(Sports.Tennis);
//What if the name contains spaces?
sports.Add(new Sport("Water Polo"));

var otherSport = new Sport("Other sport");

if(sports.Contains(otherSport)) {
    //Do something
}

foreach(var sport in sports) {
    if(sport == otherSport) {
        //Do Something
    } else if(sport == Sports.Football) {
        //do something else
    }
}

Once you do this, you'd find there is actuall very little need for having an enumeration as any conditional operations on the sport type can be handled within the Sport class.

EDIT Realised that my equality operator will throw a StackOverflowException I always keep forgetting to write Object.ReferenceEquals(obj,null) instead of obj==null, which will recurse infinitely.

Igor Zevaka
What do you think of Daniel Rose's answer?
Craig Johnston
I would chose neither. Supplementing an enumeration with stuff at runtime is a bit smelly. I would chose a consistent approach for the sports known at compile time and at run time. Example forthcoming in a little bit.
Igor Zevaka
+ i like this approach.
Sky Sanders
I would use `public const Sport Tennis = new Sport(0)` instead
tster
@tster That was my first thought too. However, you can't define instances of user defined structs or classes as consts. They have to be either simple builtin types or strings. You an define those as readonly but then you would lose the ability to use them as case labels.
Igor Zevaka
+1  A: 

This is an interesting question, but have you considered a different approach to your problem? Take @fearofawhackplanet's comment for example...

var Sports = new Dictionary<string, int>
{
    {"Tennis", 0},
    {"Football ", 1},
    {"Squash ", 2},
    {"Volleyball ", 3},
};

Then later, Sports["PingPong"] = 4;

Sorry I don't have a direct answer to the question you asked, but maybe this can solve your problem in a different way.

dss539
A: 

If the enum can be defined at program startup, you place the enum in a separate assembly and use a bootstrapper that will recompile the enum, overwriting the old version, and then launch the actual application. It's not the cleanest method, but it works.

Stephan