Haskell graph data type representation

Question

I want to represent a graph in Haskell in the following manner:

For each node I want to store it's value and a list of adjacent nodes,the problem which i'm having difficulties with is that I want the adjacent nodes to be stored as references to other nodes.

For example: I want node ny to be stored as („NY“ (l p)) where l and p are adjacent nodes,and not as („NY“ („London“ „Paris“)).
I tried something like this :

data Node a = Node { value :: a
                   , neighbors :: [Node a]
                   }deriving (Show)

let n1 = Node {value=1, neighbors=[n2]}
let n2 = Node {value=1, neighbors=[n1 n3]}
let n3 = Node {value=1, neighbors=[n2]}

But i get en error in let,What am I doing wrong ?

Answer 1

Two problems:

1. let is an expression form and at top level the compiler is expecting a declaration form.

2. You need a single nest of bindings; by using three lets, you've split the definitions into three separate scopes.

The following code compiles, and when I ask for n1, I get an infinite string printout as expected:

module Letnest 
where
data Node a = Node { value :: a
                   , neighbors :: [Node a]
                   } deriving (Show)

n1 = Node {value=1, neighbors=[n2]}
n2 = Node {value=1, neighbors=[n1, n3]}
n3 = Node {value=1, neighbors=[n2]}

Answer 2

I wouldn't represent a graph this way. Store the nodes in a Map or an Array and refer to them by their keys instead of directly pointing to them. This would be much easier to save, load, maintain, and work with.

For some problems with your current representation:

Reid Barton commented:

Note that n1 and n3 are completely indistinguishable (since they have the same definition) which, depending on your application, may be a problem with this representation.

(there is no is comparison a la Python in Haskell)

Norman Ramsey noticed:

I get an infinite string printout