ansaurus

Question

Answer 1

+3 A:

You're assigning instead of comparing:

if (day = 5;) {

Should be:

if (day === 5) {

If you're not familiar with === .. it is the same as == except it is strict (does not perform type coercion).

You can read more about comparison operators here.

Edit:

Also be sure to read John's answer, because it looks like that is contributing to your problem as well.

Matt 2010-05-07 17:12:31

I think (day == 5) should be enough.

Hellnar 2010-05-07 17:14:10

@Hellnar - in this specific case, yes. But `==` is one of JavaScript's bad parts. `===` is more predictable and it is a good habit to use it by default.

Matt 2010-05-07 17:15:26

Answer 2

+7 A:

Most likely, you're running into an issue where the script executes before the elements are part of the DOM. So, wrap your script like this:

<script type="text/javascript"> 

  $(document).ready(function() {
    var rightNow = new Date(); 
    var day = rightNow.getUTCDay(); 
    if (day == 5) { 
      $('#friday').hide(); 
    } 
  });
</script>

Notice that I also fixed the "day = 5;" mis-condition.

John Fisher 2010-05-07 17:14:06

+1 it looks like he's running his script before the DOM is ready.

Matt 2010-05-07 17:16:34

I'm still missing something. I just can't find it.

Ryan 2010-05-07 17:17:53

you nailed it, the div isn't there yet, too bad defer isn't supported across the board

curtisk 2010-05-07 17:19:11

@Ryan, if you're still having trouble after putting this script into your code, update your post to show the new code. Then, we can see what your new problem is.

John Fisher 2010-05-07 17:22:38

<html><head><script type="text/javascript"> $(document).ready(function() { var rightNow = new Date(); var day = rightNow.getUTCDay(); if (day == 5) { $('#friday').hide(); } });</script></head><body><div id='friday'>friday</div><br><div id='saturday'>saturday</div><br><div id='sunday'>sunday</div><br></body></html>

Ryan 2010-05-07 17:24:11

Did I not post that code correctly?

Ryan 2010-05-07 17:27:01

@Ryan: That new HTML isn't including JQuery, so you would get javascript errors trying to run the jquery code.

John Fisher 2010-05-07 17:27:15

@Ryan: You should actually "Edit" the existing question, rather than trying to put code in comments.

John Fisher 2010-05-07 17:27:57

I edit the new question and put up code.

Ryan 2010-05-07 17:50:42

@Ryan what is still going wrong? Does is work if you replace rightNow.getUTCDay() with a simple 5?

Kathy Van Stone 2010-05-07 19:07:11

Answer 3

+1 A:

i suggest John Fishers answer.

the only thing that you could do to expand on it would be to put the day in a switch, assuming you want to hide each item depending on the day rather than ONLY hide on friday if it's 5

<script type="text/javascript"> 

  $(document).ready(function() {
    var rightNow = new Date(); 
    var day = rightNow.getUTCDay(); 
    switch(day)
    {
      case 0:
        //whatever you want to do on 0
        break;
      case 1:
        //whatever you want to do on 1
        break;
      case 2:
        //whatever you want to do on 2
        break;
      case 3:
        //whatever you want to do on 3
        break;
      case 4:
        //whatever you want to do on 4
        break;
      case 5:
        $('#friday').hide(); 
        break;
      case 6:
        //whatever you want to do on 6
        break;
  });
</script>

David Larrabee 2010-05-07 17:25:19

Answer 4

A:

The only problem with the latest code you just posted is that you removed your jQuery include (as John Fisher pointed out). Put the line

<script type="text/javascript" src="http://code.jquery.com/jquery-latest.js"&gt;&lt;/script&gt;

back in and it will work as you want it to.
To handle the after 5pm problem you would do this:

$(document).ready(function() {
    var rightNow = new Date(); 
    var day = rightNow.getUTCDay();
    if (day == 5 || rightNow.getHours() > 17) { 
      $('#friday').hide(); 
    } 
});

Here's a good reference on the javascript date object.

rosscj2533 2010-05-07 18:02:48

Thank you works perfect.

Ryan 2010-05-07 18:19:45

ansaurus

tags:

views:

answers:

JQuery hide div based on day

related questions