views:

213

answers:

2

Hello,

I am a very basic user and do not know much about commands used in C, so please bear with me...I cant use very complicated codes. I have some knowledge in the stdio.h and ctype.h library, but thats about it. I have a matrix in a txt file and I want to load the matrix based on my input of number of rows and columns

For example, I have a 5 by 5 matrix in the file. I want to extract a specific 2 by 2 submatrix, how can I do that ?

I created a nested loop using :

FILE *sample
sample=fopen("randomfile.txt","r"); 
for(i=0;i<rows;i++){
  for(j=0;j<cols;j++){
     fscanf(sample,"%f",&matrix[i][j]);
   }
 fscanf(sample,"\n",&matrix[i][j]);
}
fclose(sample);

Sadly the code does not work .. If I have this matrix :

5.00 4.00 5.00 6.00 
5.00 4.00 3.00 25.00 
5.00 3.00 4.00 23.00 
5.00 2.00 352.00 6.00

And inputting 3 for row and 3 for column, I get :

5.00 4.00 5.00
6.00 5.00 4.00
3.00 25.00 5.00

Not only this isnt a 2 by 2 submatrix, but even if I wanted the first 3 rows and first 3 columns, its not printing it correctly....

I need to start at row 3 and col 3, then take the 2 by 2 submatrix !

I should have ended up with :

4.00 23.00 
352.00 6.00

I heard that I can use fgets and sscanf to accomplish this. Here is my trial code :

fgets(garbage,1,fin);
sscanf(garbage,"\n");

But this doesnt work either :(

What am I doing wrong ?

Please help. Thanks !

+4  A: 

OK, so you want to read a submatrix of size n x m, starting at positions x, y in the big matrix of size p x q. You need two things:

  1. (verify that x + n <= p and y + m <= q)
  2. skip to the first element of the matrix you want to read. This requires first skipping the first y - 1 rows
  3. skip x - 1 elements from the next row, then read n elements into your submatrix. Repeat m times.

Your current implementation starts reading from the very first element of the matrix, then reads elements contiguously into the submatrix. An updated version:

FILE *sample = fopen("randomfile.txt", "r");
// skip the first y-1 rows
for (i = 0; i < y - 1; i++) {
  fscanf(sample, "%*[^\n]\n", &matrix[i][j]);
}
for (i = 0; i < m; i++) {
  // skip the first x-1 numbers
  for (j = 0; j < x - 1; j++) {
     fscanf(sample, "%*f");
  }
  // read n numbers
  for (j = 0; j < n; j++) {
     fscanf(sample, "%f", &matrix[i][j]);
  }
  if (x + n < p) {
    // consume the rest of the line
    fscanf(sample, "%*[^\n]\n");
  }
}
fclose(sample);

Update: to read the submatrix from an array instead is even simpler, just requires a bit more calculation. The gist is, a matrix of size p x q can be stored in a contiguous array of size p x q such that matrix[i,j] can be read from array[i*(j-1)+j] (approximately - there may be off-by-one errors and I am never sure which is the column and which is the row, but hopefully you get the idea :-)

So the code would be something like

for (i = 0; i < m; i++) {
  for (j = 0; j < n; j++) {
     submatrix[i][j] = array[(y + i) * p + x + j];
  }
}
Péter Török
Thanks for replying. What if the matrix is 50x25. Am I going to use the row or column for comparison ? n=2 , x+2<50 or x+2<25 ?
ZaZu
@ZaZu, just updated the dimensions for the general case.
Péter Török
Thank you very much, my code turned out to be somewhat similar but I had an error of forgetting to read it into a new matrix. I have a question though, what if the large matrix is not part of a file ? What if a user enters a matrix in an array, and then needs to extract a submatrix from it. How will the scanf syntax change ?
ZaZu
Yes a standard input. I tried doing that, and replacing sample by the original array. I got this : scanf(matrix[i][j],"%*[^\n]\n", --Where sub is the submatrix array... but that didnt work ..It gives an error Argument no 1 of 'scanf' must be of type '<ptr>char', not 'float'
ZaZu
This is my refined scan function : scanf("%*[^\n]\n",matrix[i][j], -- Is this correct ?
ZaZu
@ZaZu, if you already have the numbers in memory (whether in an array or any other data structure), you don't need scanf anymore - you can just assign values directly. See my update, even if it is not exactly what you want (as I am not sure I understand that right), hopefully it points you to the right direction.
Péter Török
Thank you for the info, so for the option of choosing a submatrix from numbers in the memory, I should use this loop only ? Ok sounds good, but am I supposed to declare array[] as a new array ? Or can I use matrix[][] ?
ZaZu
@ZaZu, I used an array because you mentioned in your comment above that "a user enters a matrix in an array". For a matrix, the innermost statement in the loop should be `submatrix[i][j] = bigmatrix[y + i][x + j]`
Péter Török
@Peter, I got this now : user enters 3 by 3 matrix. Then to extract, chooses row 2, and col 2. if the big matrix was `[ 1 1 1 ] [1 2 3 ] [ 1 4 5]`, they should extract `[ 2 3 ] [ 4 5 ]` .. What I get is the first number (2), and then the program fails. All I did was add `bigmatrix[i+col][j+row]` .. isnt this correct ?
ZaZu
@ZaZu, are you sure you get 2 and not 5? Note that in C/C++, arrays are indexed from 0, so the element in the middle of a 3x3 matrix would be `bigmatrix[1][1]`. You must always be clear about whether you are using 0 or 1 based indexes in your calculations.
Péter Török
@Peter, Hmm yeah, you're right. Well I dont know what happened, im not getting any number .. It simply crashes before it gives 2 or a 5 ... it should be `[i+col][j+row]` right ?
ZaZu
@ZaZu, so as it seems that your `row` and `col` are 1 based, you should decrement them by 1 in the index calculations, i.e. `bigmatrix[i+col-1][j+row-1]`.
Péter Török
@Peter .. AHHHH that did the trick, I was going ahead of the col and row by 1 right ? is this why it crashed ? What do you mean 1 based ? I start the loop by i=0 and and increment until i<2 .. Isnt this 0 based ? it starts at 0 :S .. Please explain ! Thanks :D
ZaZu
ZaZu
Péter Török
Thanks works perfectly, I forgot to reference it back to a structure that I have.I really appreciate that you kept up with me all along, thank you very much.
ZaZu
+1  A: 

Let's take this in stages. First a couple of minor fixes to your code:

for(i=0;i<rows;i++){
  for(j=0;j<cols;j++){
    float dummy;  /* this will make thing easier later */
    fscanf(sample,"%f",&dummy);
    matrix[i][j] = dummy;
  }
/* fscanf(sample,"\n",&matrix[i][j]); this isn't even legal */
}

Now we define what we want:

int startrow = 2; /* The starting index. Remember we index 0,1,2,3 */
int startcol = 2;
int resultrows = 2; /* How many rows we want in our answer */
int resultcols = 2;
float result[resultrows][resultcols];

Now we ignore what we don't want:

for(i=0;i<rows;i++){
  for(j=0;j<cols;j++){
    float dummy;
    fscanf(sample,"%f",&dummy);
    if(i >= startrow && i < startrow + resultrows &&
       j >= startcol && j < startcol + resultcols){
      matrix[i][j] = dummy;
    }
  }
}

Notice that now only the values we want are copied into matrix, the rest of matrix is uninitialized gibberish. Now write it into result instead:

for(i=0;i<rows;i++){
  for(j=0;j<cols;j++){
    float dummy;
    fscanf(sample,"%f",&dummy);
    if(i >= startrow && i < startrow + resultrows &&
       j >= startcol && j < startcol + resultcols){
      result[i-startrow][j-startcol] = dummy;
    }
  }
}

EDIT:
If you want to copy a submatrix from a larger matrix already in memory, the inner loop should be

for(j=0;j<cols;j++){
  if(i >= startrow && i < startrow + resultrows &&
     j >= startcol && j < startcol + resultcols){
      result[i-startrow][j-startcol] = matrix[i][j];
  }
}
Beta
Thank you very much for taking your time and writing this, im testing this and hopefully Ill get it to work. Thanks
ZaZu
I tried using your method but I preferred Peter's way because its similar to the way my course is given .. Thank you though, really appreciate it.
ZaZu