ansaurus

Question

Keep Hibernate Initializer from Crashing Program

Answer 1

+1 A:

The static initializer in SessionFactoryUtil has a try/catch for all instances of Throwable but your main try/catch block only catches Exceptions. I'd change it to catch Throwables as well and see if that solves the problem.

Steven Paligo 2010-05-11 20:09:26

@Steven: Unfortunately it had the same effect.

manyxcxi 2010-05-11 21:00:28

@Steven: I read your solution incorrectly. I implemented catching throwable in my main try/catch (like you said) and that solved it. It was a long day.

manyxcxi 2010-05-12 18:13:23

@manyxcxi I'm glad that helped. Good luck with your project and thanks.

Steven Paligo 2010-05-13 14:59:49

Answer 2

A:

Well, depending on what type of application you write, static initializers doing anything that reaches outside of the JVM are usually a bad idea.

To the problem: if I read you code correctly, you first catch all Throwables in the static initalizer of SessionFactoryUtil, write an error message to standard error an then throw a new ExceptionInInitializerError yourself, wrapping the catched Throwable in it.

IIRC static initializers are invoked first thing after the class was loaded. The stack trace tells us this happens probably from the main method in class RtaMain, as SessionFactoryUtil.getSessionFactory() seems to be invoked from there, which triggers the class load.

To catch this error you need a try/catch surrounding the call to getSessionFactory() in the main method of your class RtaUtil, catching Throwable, or at least the specific throwable you throw in your static initializer yourself, which is ExceptionInInitializerError.

HTH

Ralf Fischer 2010-05-11 23:22:21

Answer 3

A:

It still manages to break out of this try/catch and crash the main thread.

As mentioned, this bloc in your main method won't catch the ExceptionInInitializerError thrown in your static initializer:

catch(Exception ex) {
    logger.error("Error initializing hibernate")
}

If you want to catch both Exception and Error, you should catch (Throwable t) (by the way, I noticed you said you changed that but I'd like to see what you changed exactly and the error you get.

But to be honest, if the SessionFactory fails at being initialized, I wonder what you're going to do in your main method and it's actually a common practice to let the program fail in that case.

Last thing, the try/catch in this part seems totally useless:

public static SessionFactory getSessionFactory() {
    try {
        return sessionFactory;
    } catch(Exception ex) {
        return null;
    }
}

You can remove it safely.

Pascal Thivent 2010-05-12 07:28:41

@Pascal: Steven was correct, I implemented his solution in the wrong spot in my code initially. The main issue I have with needing to catch everything and close gracefully is that the program updates a status xml file that keeps a number of web apps updated as to what is happening. When I catch a fatal exception the program stops its normal execution path, updates the status file that it is finished but had errors and shuts down. I don't expect to have hibernate issues as it was a typo in an hbm.xml file but I didn't want to leave loose ends.

manyxcxi 2010-05-12 18:16:33

ansaurus

tags:

views:

answers:

Keep Hibernate Initializer from Crashing Program

related questions