views:

153

answers:

4

In C# it is possible to create weak references to objects as described here:

WeakReference Class

In .net some classes also implement the IDisposable interface. Calling the Dispose method of this interface is performed to manually dispose of any managed or unmanaged resources currently being held onto. An example might be a Bitmap object or class.

If I assign an object that implements IDisposable to a weak reference, will Dispose be called if the weak reference collects the object?

+2  A: 

No. Simple like that ;)

TomTom
+2  A: 

GC does not ever call Dispose. Dispose must be called by user code.

Stephen Cleary
Your design may be better served by replacing `WeakReference` with `RefCountDisposable` from the [Rx library](http://msdn.microsoft.com/en-us/devlabs/ee794896.aspx).
Stephen Cleary
+2  A: 

No. Check this test:

class Program {
        static void Main(string[] args) {
            Test test = new Test();
            Console.WriteLine(test.Disposable == null);
            GC.Collect();
            Console.WriteLine(test.Disposable == null);
            Console.ReadLine();
        }
    }

    public class Test {
        private WeakReference disposable = new WeakReference(new WeakDisposable());
        public WeakDisposable Disposable {
            get { return disposable.Target as WeakDisposable; }
        }
    }

    public class WeakDisposable : IDisposable {
        ~WeakDisposable() {
            Console.WriteLine("Destructor");
        }
        public void Dispose() {
            Console.WriteLine("Dispose");
        }
    }

The output is:

False
True
Destructor

As you can see, the execution never hits the Dispose method.

Fernando
+2  A: 

In general, the answer is indeed No.

However, a properly implemented class that implements IDisposable using the IDisposable pattern (hopefuly all .NET classes do this). Would also implement finalizer which is called when the object is garbage collected and inside the finalizer, it would call Dispose. So, for all proper implementations of IDisposable, the Dispose method will be called.

(Note: the counter-example by Fernando is not implementing IDisposable properly)

Tomas Petricek
Actually, the "standard" finalizer only calls `Dispose(bool)`; `Dispose()` is not called, so any cleanup that depends on managed code (e.g., flushing underlying file streams) cannot be done.
Stephen Cleary