views:

769

answers:

5

I am trying to parse a Rss2.0 feed on Android using a Pull parser.

XmlPullParser parser = Xml.newPullParser();
parser.setInput(url.open(), null);

The prolog of the feed XML says the encoding is "utf-8". When I open the remote stream and pass this to my Pull Parser, I get invalid token, document not well formed exceptions.

When I save the XML file and open it in the browser(FireFox) the browser reports presence of Unicode 0x12 character(grave accent?) in the file and fails to render the XML.

What is the best way to handle such cases assuming that I do not have any control over the XML being returned?

Thanks.

A: 

Before parsing your XML, you may tweak it, and manually remove the accents before you parse it. Maybe not the best solution so far, but it will do the job.

Moons
drop them? I will have to use regex or maybe scan the response on a per character basis. I hope this doesn't come down to that!
Samuh
+2  A: 

I use to filter it with a regex, but the trick is not trying to get and replace the accents. It depends on the encode and you don't want to change the content.

Try to insert the content of the tags into this tags

Like this

<title>My title</title>
<link>http://mylink.com&lt;/link&gt;
<description>My description</description>

To this

<title><![CDATA[My title]]></title>
<link><![CDATA[http://milynk.com]]&gt;&lt;/link&gt;
<description><![CDATA[My Description]]></description>

The regex shouldn't be very hard to figure out. It works for me, hope it helps for you.

Erik Escobedo
By the way, I found the regex our system use:string.gsub /<link>(.*)</link>/, '<link><![CDATA[\1]]</link>'This function is for Rails, but the regex is the same for every language.
Erik Escobedo
+6  A: 

Where did you find that 0x12 is the grave accent? UTF-8 has the character range 0x00-0x7F encoded the same as ASCII, and ASCII code point 0x12 is a control character, DC2, or CTRL+R.

It sounds like an encoding problem of some sort. The simplest way to resolve that is to look at the file you've saved in a hex editor. There are some things to check:

  1. the byte order mark (BOM) at the beginning might confuse some XML parsers
  2. even though the XML declaration says the encoding is in UTF-8, it may not actually have that encoding, and the file will be decoded incorrectly.
  3. not all unicode characters are legal in XML, which is why firefox refuses to render it. In particular, the XML spec says that that 0x9, 0xA and 0xD are the only valid characters less than 0x20, so 0x12 will definitely cause compliant parsers to grumble.

If you can upload the file to pastebin or similar, I can help find the cause and suggest a resolution.

EDIT: Ok, you can't upload. That's understandable.

The XML you're getting is corrupted somehow, and the ideal course of action is to contact the party responsible for producing it, to see if the problem can be resolved.

One thing to check before doing that though - are you sure you are getting the data undisturbed? Some forms of communication (SMS) allow only 7-bit characters. This would turn 0x92 (ASCII forward tick/apostrophe - grave accent?) into 0x12. Seems like quite a coincidence, particularly if these appear in the file where you would expect an accent.

Otherwise, you will have to try to make best do with what you have:

  1. although not strictly necessary, be defensive and pass "UTF-8" as the second paramter to setInput, on the parser.

  2. similarly, force the parser to use another character encoding by passing a different encoding as the second parameter. Encodings to try in addtion to "UTF-8" are "iso-8859-1" and "UTF-16". A full list of supported encodings for java is given on the Sun site - you could try all of these. (I couldn't find a definitive list of supported encodings for Android.)

  3. As a last resort, you can strip out invalid characters, e.g. remove all characters below 0x20 that are not whitespace (0x9,0xA and 0xD are all whitepsace.) If removing them is difficult, you can replace them instead.

For example

class ReplacingInputStream extends FilterInputStream
{
   public int read() throws IOException
   {
      int read = super.read();
      if (read!=-1 && read<0x20 && !(read==0x9 || read==0xA || read==0xB))
         read = 0x20;
      return read;          
   }
}

You wrap this around your existing input stream, and it filters out the invalid characters. Note that you could easily do more damage to the XML, or end up with nonsense XML, but equally it may allow you to get out the data you need or to more easily see where the problems lie.

mdma
I cant share the file unfortunately...
Samuh
I've updated my response with some things to try.
mdma
I've tried 1 and 2 without much luck; third option is the only one left and I would most probably be going with that. Thanks for your patience and help with this one..cheers!
Samuh
Did you see the comment about SMS and 7-bit characters? It might be worthwhile getting the source to send you the XML via a different route to confirm that what you downloaded is the same as the original.
mdma
+2  A: 

The problem with UTF-8 is that it is a multibyte encoding. As such it needs a way to indicate when a character is formed by more than one byte (maybe two, three, four, ...). The way of doing this is by reserving some byte values to signal multibyte characters. Thus encoding follows some basic rules:

  • One byte characters have no MSB set (codes compatible with 7-bit ASCII).
  • Two byte characters are represented by sequence: 110xxxxx 10xxxxxx
  • Three bytes: 1110xxxx 10xxxxxx 10xxxxxx
  • Four bytes: 11110xxx 10xxxxxx 10xxxxxx 10xxxxxx

Your problem is that you may be reading some character string supposedly encoded as UTF-8 (as the XML encoding definition states) but the byte chunk might not be really encoded in UTF-8 (it is a common mistake to declare something as UTF-8 but encoding text with a different encoding such as Cp1252). Your XML parser tries to interpret byte chunks as UTF-8 characters but finds something that does not fit the encoding rules (illegal character). I.e. two bytes with two most significate bytes set would bring an illegal encoding error: 110xxxxx must be always followed by 10xxxxxx (values such as 01xxxxxx 11xxxxxx 00xxxxxx would be illegal).

This problem does not arise when non-variable length encodings are used. I.e. if you state in your XML declaration that your file uses Windows-1252 encoding but you end up using ANSI your only problem will be that non-ASCII characters (values > 127) will render incorrectly.


The solution:

  1. Try to detect encoding by other means.
    • If you will always be reading data from same source you could sample some files and use an advanced text editor that tries to infer actual encoding of the file (i.e. notepad++, jEdit, etc.).
    • Do it programatically. Preprocess raw bytes before doing any actual xml processing.
  2. Force actual encoding at the XML processor

Alternatively if you do not mind about non-ASCII characters (no matter if strange symbols appear now and then) you could go directly to step 2 and force XML processing to any ASCII compatible 8-byte fixed length encoding (ANSI, any Windows-XXXX codepage, Mac-Roman encoding, etc.). With your present code you just could try:

XmlPullParser parser = Xml.newPullParser();
parser.setInput(url.open(), "ISO-8859-1");
Fernando Miguélez
thanks for your answer!
Samuh
+1  A: 

Calling setInput(istream, null) already means for the pull parser to try to detect the encoding on its own. It obviously fails, due to the fact that there is an actual problem with the file. So it's not like your code is wrong - you can't be expected to be able to parse all incorrect documents, whether ill-formed or with wrong encodings.

If however it's mandatory that you try to parse this particular document, what you can do is modify your parsing code so it's in a function that takes the encoding as a parameter and is wrapped in a try/catch block. The first time through, do not specify an encoding, and if you get an encoding error, relaunch it with ISO-8859-1. If it's mandatory to have it succeed, repeat for other encodings, otherwise call it quits after two.

JRL