views:

162

answers:

1

I was using this extension method to transform very large xml files with an xslt.

Unfortunately, I get an OutOfMemoryException on the source.ToString() line.

I realize there must be a better way, I'm just not sure what that would be?

public static XElement Transform(this XElement source, string xslPath, XsltArgumentList arguments)
{
        var doc = new XmlDocument();
        doc.LoadXml(source.ToString());

        var xsl = new XslCompiledTransform();
        xsl.Load(xslPath);

        using (var swDocument = new StringWriter(System.Globalization.CultureInfo.InvariantCulture))
        {
            using (var xtw = new XmlTextWriter(swDocument))
            {
                xsl.Transform((doc.CreateNavigator()), arguments, xtw);
                xtw.Flush();
                return XElement.Parse(swDocument.ToString());
            }
        }
}

Thoughts? Solutions? Etc.

UPDATE: Now that this is solved, I have issues with validating the schema! http://stackoverflow.com/questions/2884966/validating-large-xml-files

+6  A: 

Try this:

using System.Xml.Linq;
using System.Xml.XPath;
using System.Xml.Xsl;

static class Extensions
{
    public static XElement Transform(
        this XElement source, string xslPath, XsltArgumentList arguments)
    {
        var xsl = new XslCompiledTransform();
        xsl.Load(xslPath);

        var result = new XDocument();
        using (var writer = result.CreateWriter())
        {
            xsl.Transform(source.CreateNavigator(), arguments, writer);
        }
        return result.Root;
    }
}

BTW, new XmlTextWriter() is deprecated as of .NET 2.0. Use XmlWriter.Create() instead. Same with new XmlTextReader() and XmlReader.Create().

John Saunders
@Jeff: good catch. Fixed.
John Saunders
Right on - +1 then!
Jeff Sternal
Thanks, this works great! I've added a follow up question related to validating (xsd) http://stackoverflow.com/questions/2884966/validating-large-xml-files
Chad