ansaurus

Question

Jquery Javascript function, simple error, can't find it!

Answer 1

+1 A:

Presumably you are passing through something to the applyThresholds function where innerHTML on myvalue is not valid. Does it work ok in firefox etc?

My guess would be that the crazy document.getElementsByTagName('B')[36]; code is just returning undefined at some point. You should put some code in applyThresholds to check to see if you are getting invalid arguments through. Something like:

if(myvalue == null || mycell == null) {
   return;
}

Nathan Reed 2010-05-30 03:53:40

Answer 2

+1 A:

You would be far better off, if possible, using ids on your elements, and then using document.getElementById() (or, better yet, using Dojo, MooTools or JQuery to make your code simpler).

So your html looks like:

<td id="cell-repair-video">Repair value is <b>23</b></td>
<td id="cell-ppv">PPV value is <b>5</b></td>

Then your JavaScript looks like:

var RepairVideo_cell = document.getElementById("cell-repair-video");
var RepairVideo_value = RepairVideo_cell.getElementsByTagName("b")[0];

In JQuery (and others), you can easily use a class to determine which elements need thresholding

In this case, your html looks like:

<td class="threshold">Repair value is <b>23</b></td>
<td class="threshold">PPV value is <b>5</b></td>

And your entire JavaScript looks like:

$(function() {
  var threshValue = 10;
  $('.threshold').each(function(index) {
    var thisValue = parseFloat( $('b', this).text() );
    if(thisValue > threshValue) {
      $(this).addClass('overThreshold');
    }
  });
});

In your current example, there is an error in your CSS

To style td and th elements with a classname, go

td.overThreshold, th.overThreshold {
  background: #F00; /* for example */
}

kibibu 2010-05-30 04:39:12

Ok I used your script like so<script>$(function() { var threshValue = 10; $(".threshold").each(function(elem) { if($("b",elem).innerText > threshValue) { elem.addClass("overThreshold"); } });});</script>And then set <body onLoad='function()'>However, nothing is working, and I am using <script src='jquery-1.4.2.min.js' type='text/javascript'></script>

CodingIsAwesome 2010-05-31 01:12:39

no need for the onLoad thing, that's what the surrounding $() does. Are you including the JQuery script first? Have you got some css for `.overThreshold`? Try adding `<style type="text/css">.overThreshold{ background: #F00; }</style>` in the head

kibibu 2010-05-31 01:55:04

Oh i see you've changed the question. What does your html look like?

kibibu 2010-05-31 01:57:05

Try the updated version

kibibu 2010-05-31 01:57:59

I've updated the question to show all the code in the page. Thank you for helping me. I'm a Javascript and Jquery newb, and your help is greatly appreciated :)

CodingIsAwesome 2010-05-31 02:04:29

Updated, please try now.

kibibu 2010-05-31 03:22:18

You good sir, are a AMAZING!

CodingIsAwesome 2010-05-31 03:47:07

It works and I learned something!

CodingIsAwesome 2010-05-31 03:47:47

No worries! Glad to help.

kibibu 2010-05-31 04:28:27

ansaurus

tags:

views:

answers:

Jquery Javascript function, simple error, can't find it!

related questions