views:

139

answers:

2

Given the following code (it's a macro that generates code for a list data structure, based on the contained type).

list.h

#ifndef _LIST_H
#define _LIST_H

#ifdef __cplusplus
extern "C" {
#endif

#define LIST_TEMPLATE_INIT(type) \
    typedef struct __list_s_##type { \
        struct __list_s_##type *next; \
        type value; \
    } __list_##type; \
\
    __list_##type * __list_##type##_malloc(type value){ \
        __list_##type * list = NULL; \
        list = malloc(sizeof(*list)); \
        list->value = value; \
        return list; \
    }\
\
    void __list_##type##_free(__list_##type *list){\
        __list_##type * back = list;\
        while(list=list->next){\
            free(back);\
            back = list;\
        }\
    }
#define LIST_TYPE(type) __list_##type
#define LIST_MALLOC(type,value) __list_##type##_malloc(value)
#define LIST_FREE(type,list) __list_##type##_free(list)
#define LIST_DATA(list) (list->value)

#ifdef __cplusplus
}
#endif

#endif /* _LIST_H */

And here is how the above code works:

#include <stdio.h>
#include <stdlib.h>
#include "list.h"

/*
 * 
 */
LIST_TEMPLATE_INIT(int)
int main(int argc, char** argv)
{
 LIST_TYPE(int)* list = NULL;
 list = LIST_MALLOC(int, 5);
 printf("%d",LIST_DATA(list));
 LIST_FREE(int,list);
 return (0);
}

My question, is it possible to somehow be able to call : LIST_TEMPLATE_INIT(int), as many times as I want, in a decentralized fashion ?

The current issue with this right now is that calling LIST_TEMPLATE_INIT(int) in another file raise compilation errors (because of function redefinition):

Example of error:

error: redefinition of ‘struct __list_s_int’
 error: redefinition of ‘struct __list_s_int’
error: conflicting types for ‘__list_int’
note: previous declaration of ‘__list_int’ was here
error: conflicting types for ‘__list_int_malloc’
note: previous definition of ‘__list_int_malloc’ was here
error: conflicting types for ‘__list_int_free’
note: previous definition of ‘__list_int_free’ was here
A: 

Make the underlying struct type anonymous. This will allow you to define as many as your heart desires:

#define LIST_TEMPLATE_INIT(type) \
    typedef struct { \
        struct __list_s_##type *next; \
        type value; \
    } __list_##type; \
JSBangs
Can you please be more specific ? Are you sure is going to work ? The problem is not only with the structure, but also with the functions.
Andrei Ciobanu
This will not work, since the `next` pointer has to be of the same type as the list struct.
e.James
+4  A: 

I would suggest creating different macros to declare and define the list structure, then using separate header and source files for each:

list.h:

#ifndef _LIST_H    
#define _LIST_H    

#define LIST_TEMPLATE_DECLARE(type)                   \
    struct __list_##type;                             \
    typedef struct __list_##type __list_##type;       \
    struct __list_##type {                            \
        struct __list_##type * next;                  \
        type value;                                   \
    };                                                \
                                                      \
__list_##type * __list_##type##_malloc(type value);   \
void __list_##type##_free(__list_##type * list);

#define LIST_TEMPLATE_DEFINE(type)                    \
__list_##type * __list_##type##_malloc(type value) {  \
    __list_##type * list = NULL;                      \
    list = malloc(sizeof(*list));                     \
    list->value = value;                              \
    return list;                                      \
}                                                     \
void __list_##type##_free(__list_##type * list) {     \
    __list_##type * back = list;                      \
    while(list=list->next){                           \
        free(back);                                   \
        back = list;                                  \
    }                                                 \
}

#define LIST_TYPE(type) __list_##type    
#define LIST_MALLOC(type,value) __list_##type##_malloc(value)    
#define LIST_FREE(type,list) __list_##type##_free(list)    
#define LIST_DATA(list) (list->value)    

#endif /* _LIST_H */    

int_list.h:

#ifndef INT_LIST_H_
#define INT_LIST_H_

#include "list.h"
LIST_TEMPLATE_DECLARE(int)

#endif /* INT_LIST_H_ */

int_list.c:

#include "int_list.h"

LIST_TEMPLATE_DEFINE(int)

other.c:

#include "int_list.h"

int some_function(int argc, char** argv)
{
    LIST_TYPE(int)* list = NULL;
    list = LIST_MALLOC(int, 5);
    printf("%d",LIST_DATA(list));
    LIST_FREE(int,list);
    return (0);
}
e.James
extern C is redundant wrapping the macro definition - should be moved to init_list.h or added to the macro itself appropriately
Greg Domjan
Good call. I'll remove it.
e.James