If no error contiune.. if error occurse do else

Question

hi i have a question i have some code that works good on like 70% of the computers i use it on but.. for some reason theres a few that are pesky and id like to do something like this (keep in mind this is a hypothetical)

private void test_click(object sender, EventArgs e)
{
  MessageBox.Show("hi");
  //if it works ok without a error it continues to
  MessageBox.Show("worked ok");
  //if it encountered a error of some kind it would go to
  MessageBox.Show("DID NOT WORK OK");
}

Answer 1

I would suggest log information rather then pops up messages.

Answer 2

What about try-catch (or try-catch-finally)?

private void test_click(object sender, EventArgs e)
{
  MessageBox.Show("hi");
  try
  {
     //if it works ok without a error it continues to
     MessageBox.Show("worked ok");
  }
  catch( Exception )
  {  
    //if it encountered a error of some kind it would go to
    MessageBox.Show("DID NOT WORK OK");
  }
}

Attention: Here I use a global catch( Exception ) which should be used with care, only! For a test method this is no problem, but do not do this in production code. You should at least specify the expected exception there and think about how to handle the situation.

Answer 3

you can use try catch.

Answer 4

When you say it doesn't work, do you mean it throws an exception, or that it just silently fails without any explanation?

If it throws an exception, you should use something like

private void test_click(object sender, EventArgs e)
{
    try
    {
        MessageBox.Show("hi");
        MessageBox.Show("worked ok");
    }
    catch(WheteverExceptionType ex)
    {
        MessageBox.Show("DID NOT WORK OK");
        // you can also access the properties of the thrown exception "ex" here...
        MessageBox.Show(ex.Message);
    }
}

Answer 5

Essentially:

try {
  MessageBox.Show("hi");
  DoSomethingThatMightFail();
  MessageBox.Show("worked ok");
} catch (DoSomethingFailedException e) {
  MessageBox.Show("Something did not work: " + e.Message);
}