jquery clone multiple instances why

Question

Hi folks, hope can help, trying out Jquery clone which seems to work, but I get "multiple" clones not single clones on "repressing" the button.

e.g.: I want to clone this :

echo '<select class="hello">';
    foreach ($pageposts as $post):
    echo '<option>'.$post->post_title.'</option>';
    endforeach;
    echo '</select>';

on click of this

echo '<input type="button" id="rp" value="add">';

Yes from WordPress and Yes the "hello" class is from the JQuery pages

My JQuery function is:

$j=jQuery.noConflict();
$j(document).ready(function() {
$j('#rp').click(function(){ 
$j('.hello').clone().appendTo('#goodbye');
});
});

So my "overall code snippit" looks like this:

echo '<select class="hello">';
foreach ($pageposts as $post):
echo '<option>'.$post->post_title.'</option>';
endforeach;
echo '</select>';
echo '<div id="goodbye"></div>';
echo '<input type="button" id="rp" value="add">';

I clone "once" on the first press, but then it goes in multiples i.e.:

1 click gives 1 clone plus 1 original - what I want

2 clicks gives 3 clones plus 1 original - not what I want I want 1 original plus 2

3 clicks gives 7 clones plus 1 original - not what I want I want 1 original plus 3 etc.

Suggestions please. Thanks

Answer 1

It's because your selector is looking for a class:

$j('.hello')

Everytime you clone and append this to another element you're adding yet another .hello element, therefore your cloning every single .hello element it can find.

Perhaps you should remove the class name when it's been cloned:

$j('.hello').clone().removeClass('hello').appendTo('#goodbye');

Or perhaps even change it:

$j('.hello').clone().removeClass('hello').addClass('cloned_hello').appendTo('#goodbye');

You might want to add a different class so your CSS will still work, but ultimately this is why you're getting multiple cloned items.

Answer 2

Hi,

the behaviour is normal, because you clone every element that has the hello class in it.

Try this :

$j('.hello').clone().attr("class","cloned").appendTo('#goodbye');

And you put in your css the same in .cloned as in .hello .

Hope it helps :)