Should We Instantiate Data Context & Repository In Controller?

Question

I have an ObjectContext and a Repository that gets passed the ObjectContext. I then use the repository to make calls. I want to use dependency injection to not always have to instantiate the ObjectContext and Repository. What "object" would I group the context / repository into?

using (MOSContext db = new MOSContext())
{
    IUserRepository users = new UserRepository(db);

    // Do stuff with users.
}

Is this bad to do the above? Ideally, I'd like to be able to create "some object" that acts like the ObjectContext, but has accessors to all repository interfaces:

using (IDAL dal = IoC.Resolve<IDal>())
{
    dal.Users.GetById(myId);
    dal.Profiles.Add(new Profile());
}

Then using DI, I can register the context and all implementations for each repository interface.

Answer 1

Yes, it's bad to new up OCs in the controller. Yes, it's better to use DI to return an instance of an interface not strictly tied to the EF.

You should have one instance of the OC per request, not per method. Most DI containers have a request-scoped lifetime feature out of the box.