ansaurus

Question

Expression<TDelegate>.Compile in Medium Trust environment

Answer 1

A:

What is plan? Does it relate to only public types; and if nested, is/are the containing type(s) public?

I suspect this is necessary for Compile()

Marc Gravell 2010-07-07 12:59:52

plan is an Expression that represents an execution plan, I've added more details about it to the question

Adam 2010-07-07 13:09:52

Answer 2

A:

The underlying problem here is that the type being passed to System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes) is either not public, or has a constructor that is not public.

Now - given the simplicity of your code example versus the depth of the stacktrace I believe the problem lies not in plan, but in an expression within plan (since you say in your comment on Marc's answer that it is also an expression) that references the type which is then restricted.

The expression that is the source of the error here is a ConstantExpression which must be of the restricted type.

The only confusing thing about this, however, is that the type argument that AddGlobal passes to Activator.CreateInstance is StrongBox<T>, which is public and has a public constructor - which would imply that this error should be impossible.

Perhaps, however, there is something hidden associated with StrongBox that we can't see through Reflector.

So, I would be looking at the whole expression tree represented by plan and examining all the types referenced in ConstantExpressions to ensure they are all accessible. If after doing that all types are shown to be accessible, this error still occurs then it could be a bug in the framework.

However - I would have thought that such a bug would've been found already for something as simple as a ConstantExpression!

The underlying problem here is that the type being passed to System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes) is either not public, or has a constructor that is not public.

Now - given the simplicity of your code example versus the depth of the stacktrace I believe the problem lies not in plan, but in an expression within plan (since you say in your comment on Marc's answer that it is also an expression) that references the type which is then restricted.

The expression that is the source of the error here is a ConstantExpression which must be of the restricted type.

The only confusing thing about this, however, is that the type argument that AddGlobal passes to Activator.CreateInstance is StrongBox<T>, which is public and has a public constructor - which would imply that this error should be impossible.

Perhaps, however, there is something hidden associated with StrongBox that we can't see through Reflector.

So, I would be looking at the whole expression tree represented by plan and examining all the types referenced in ConstantExpressions to ensure they are all accessible. If after doing that all types are shown to be accessible, this error still occurs then it could be a bug in the framework.

However - I would have thought that such a bug would've been found already for something as simple as a ConstantExpression!

EDIT (Replacing Previous Edit) WITH THE ANSWER

I've got it, and it's a very subtle problem. You can reproduce with this little bit of code in an aspx page that is configured to run in medium trust:

Type t = typeof([any type you fancy]);
Expression expr = Expression.Constant(t);
var lambda = Expression.Lambda<Func<Type>>(expr);
var del = lambda.Compile();
Response.Write(del().ToString());

So, in the code you've provided, it's the expression representing the second argument to ChangeType (took me a while to realise that that is a Sub Sonic method), which appears to be a Type (can't see the code but I think it's a reasonable guess!).

It's baked in the expression as a ConstantExpression of a Type instance. Don't ask how I narrowed down the parameter - lots of stack crawling and reflector work ;)

As mentioned in the first half of my answer, it's difficult to see how the code that the Expression Tree compiler uses can ever create a MethodAccessException, since it's always accessing the public ctor of the StrongBox<T> type.

However, it would get upset if the type passed in as the generic is not public. "But wait," you say, "Type is public!".

That might be, but the Type instance returned at runtime from typeof() or GetType() or whatever isn't - as it's an instance of RuntimeType - which is internal.

Which is also why the above code snippet will also trigger the same error.

The fix

Change the code that produces the Type argument for ChangeType(,) from

Expression.Constant([type])

(which I'll almost guarantee that it is at the moment) to

Expression.Constant([type], typeof(Type))

This works, because you're explicitly telling the compiler to use the public Type for the constant, instead of the reflected type of RuntimeType.

You can test this fix by applying it to my example code in the previous block and re-running.

Andras Zoltan 2010-07-07 13:34:55

Thanks this is really helpful, do you have any suggestion on a quick way to track down the non accessible types?I'm pretty confident this isn't a framework bug but I'm finding pinpointing the exact cause a significant challenge.

Adam 2010-07-07 18:26:10

Hmmm... well I considered how you could do this. Perhaps you can use an expression visitor which looks for `ConstantExpression` whose type is either not public or which has at least one non-public constructor-that should narrow it down. MSDN has a link to an example expression visitor. I'll take a look and post it up on the answer.

Andras Zoltan 2010-07-07 20:19:02

@Adam - I have updated my answer with some code that might be able to help you diagnose, alongside that link from the MSDN which you'll need for an Expression Tree Visitor.It's not perfect - but it should set you on your way pretty well I hope :)

Andras Zoltan 2010-07-07 20:56:55

@Andras - this is awesome thanks, I'll let you know how I get on :)

Adam 2010-07-08 09:25:27

Hmmm... The only two dodgyConstants returned are System.Int32 and System.String

Adam 2010-07-08 13:00:31

@Adam: oh dear, this is a little strange... The stack trace doesn't lie, so therefore perhaps this is something bigger. There are some issues with generating code in medium trust (the RestrictedMemberAccess permission mentioned by the first commenter on your question) - but the MSDN documentation on Expression Trees doesn't mention requiring anything special for to actually do anything. You could try requesting the RestrictedMemberAccess permission - I just can't see any reason why you actually need it...

Andras Zoltan 2010-07-08 15:59:31

Yep, that's what I'm trying to get to the bottom of. I know I can add that permission and skip the problem but I'm trying to fix an issue in SubSonic (http://subsonicproject.com) so it can be used in medium trust. Debugging the issue is proving problematic to say the least though hence the question. Thanks for your help so far :)

Adam 2010-07-08 17:33:56

I reckon we can reproduce this overall issue in a test environment... I'll have a poke about and see what I can find.

Andras Zoltan 2010-07-09 07:24:47

@Adam - I've figured it out (I hope). Please see my updated answer - it's a real keeper of a problem!

Andras Zoltan 2010-07-09 10:16:05

@Andras - Honestly can't thank you enough for this. Amazing detective work you're absolutely right. Thanks again :)

Adam 2010-07-10 13:45:17

@Adam - not a problem - a fascinating bug and glad to be of help. Good luck with your work on Subsonic :)

Andras Zoltan 2010-07-10 17:12:07

ansaurus

tags:

views:

answers:

Expression<TDelegate>.Compile in Medium Trust environment

related questions