Adding new object to generit List overwrites previous values

Question

Hi guys, I have a problem with a generic list, which consists of intances of a class i created. I am just amazed, each time I add a new object to the list, it overwrites the previous entries. Here is a code sample, i just can't beleive it. I am using visual studio 2010:

Dim translations As List(Of TranslatedValue) = New List(Of TranslatedValue)
If Session("ctlTexts") Is Nothing Then
    Dim reader As IDataReader = DataAccessFunctions.db.GetDataReader("SELECT [ControlID], [ControlTextEN], [ControlTextDE], [ControlTextBG] FROM [dbo].[tbLanguage]", GetConnectionString)

    While reader.Read()
        Dim translationBulgarian As String = String.Empty
        Dim translationGerman As String = String.Empty
        Dim translationEnglish As String = String.Empty
        Dim translationKey As String = String.Empty
        Dim currentLanguageTranslation As String = String.Empty

        If Not reader.IsDBNull(0) Then
            translationKey = reader("ControlID")
        End If
        If Not reader.IsDBNull(1) Then
            translationEnglish = reader("ControlTextEN")
        End If
        If Not reader.IsDBNull(2) Then
            translationGerman = reader("ControlTextDE")
        End If
        If Not reader.IsDBNull(3) Then
            translationBulgarian = reader("ControlTextBG")
        End If

        Select Case CurrentLanguage
            Case Language.Bulgarian
                currentLanguageTranslation = translationBulgarian
            Exit Select
            Case Language.English
                currentLanguageTranslation = translationEnglish
            Exit Select
            Case Language.German
                currentLanguageTranslation = translationGerman
            Exit Select
        End Select

        translations.Add(New TranslatedValue(translationKey, translationEnglish, translationGerman, translationBulgarian, currentLanguageTranslation))
    End While
reader.Close()
Session("ctlTexts") = translations

Answer 1

Fundamentally, you gotta ask yourself: how does the List(of T) know how to compare two TranslatedValues.

Answer 2

What do you mean? I each time add a new instance of the class to the list. I just don't get it, because i have many running examples, where i have a list of objects. I also created a sample project and everything worked. I have no idea.

Answer 3

well that really amazes me! Each time i add an object to the list, it overwrites all previous values! Here is a screenshot: http://www.myhomebills.info/genericlistoverwrited.gif

I don't get it, i add a new instance of the class each time. I tried deleting the intance but didn't work either. When reproducing this scenario in a different project it works fine:) The class i have this loop inherits System.Web.UI.Page, could this have anything to do with it?

Answer 4

I'm so stupid! :) I have declared static private members in my class :) Sorry for bothering you, and thanks for your replies!