I think there is an issue with IDisposable example.

Question

Possible Duplicate:
Am I implementing IDisposable correctly?

Hi,

I am referring this post to check the use of IDisposable.

I see an issue in Dispose method here. In the code "disposed" is used only in the

private void Dispose(bool disposing) 

method.

I believe it should be used before calling the "Dipose" method and correct implementation would be

public void Dispose()
        {
            if(!disposed )
            {
            Dispose(true);
            // This object will be cleaned up by the Dispose method.
            // Therefore, you should call GC.SupressFinalize to
            // take this object off the finalization queue
            // and prevent finalization code for this object
            // from executing a second time.
            GC.SuppressFinalize(this);
            }
        }

Am I thinking correct?

Answer 1

Given that the implementation of Dispose(disposing) checks the disposed flag anyway, why bother doing it in the Dispose() method as well?

The only downside would be that GC.SuppressFinalize could be called multiple times if you call Dispose() multiple times - but that's harmless as far as I'm aware.

Answer 2

And don't forget to clear up any unmanaged resources. Microsoft gives sample code here:

"Implement IDisposable Correctly" http://msdn.microsoft.com/en-us/library/ms244737(VS.80).aspx

-Krip