views:

98

answers:

2

Is there anything I can do to catch an AccessViolationException? It is being thrown by a unmanaged DLL that I don't control.

A: 

Hi,

you can wrap the call to the unmanaged DLL with a try-catch block. AccessViolationExceptions can be caught normally. Executing the following code shows both messages:

    try
    {
        throw new AccessViolationException();
    }
    catch (Exception e)
    {
        MessageBox.Show(e.Message);
    }
    MessageBox.Show("Still running..");
andyp
The question is, is it a good idea to do so? It may be sensible to display a nice and friendly message to the user and write a log. But working further than that is not a good idea...
Sean Farrell
Probably not, at least not if you're not absolutely positive that nothing bad happened.
andyp
That doesn't work. I've tried catching both Exception and AccessViolationException, but it ignores my catch block. I'm assuming that there is some app.config flag I need.
Jonathan Allen
@Sean, Normally I would say no, but this is dying in a logging routine and I'm far more willing to lose the log entry than the whole service.
Jonathan Allen
@Jonathan Allen: Assuming from the information given by you that you are on .NET 4, the settig would be `legacyCorruptedState­­ExceptionsPolicy=true`. See my update.
0xA3
+4  A: 

You shouldn't. An access violation is a serious problem: it is an unexpected attempt to write to an invalid memory address. As John already clarified, the unmanaged DLL might already have corrupted the process memory before the access violation has been raised. This can have unpredicted effects on any part of the current process.

The safest thing to do is to possibly inform the user and then immediately exit.

Some more details: An access violation is an OS exception (a so-called SEH or structured exception handling exception). This is a different kind of exception than the managed CLR exceptions from System.Exception. You will rarely see SEH exceptions in purely managed code, but if one occurs, e.g. in unmanaged code, the CLR will deliver it to managed code where you are also able to catch it1.

However, catching SEH exceptions is mostly not a good idea. Further details are explained in the article Handling Corrupted State Exceptions in MSDN magazine where the following text it taken from:

The CLR has always delivered SEH exceptions to managed code using the same mechanisms as exceptions raised by the program itself. This isn't a problem as long as code doesn't attempt to handle exceptional conditions that it cannot reasonably handle. Most programs cannot safely continue execution after an access violation. Unfortunately, the CLR's exception handling model has always encouraged users to catch these serious errors by allowing programs to catch any exception at the top of the System.Exception hierarchy. But this is rarely the right thing to do.

1This was true until .NET 3.5. In .NET 4 the behavior has been changed. If you still want to be able to catch such kind of exceptions you would have to add legacyCorruptedState­­ExceptionsPolicy=true to the app.config. Further details in the articled linked above.

0xA3
To clarify: the reason you want to exit ASAP is that you don't know what the unmanaged DLL overwrote before it hit the Access Violation. It may have been writing garbage in enough places that your program cannot safely continue.
John Saunders
@John Saunders: Thanks for the clarification. I updated my answer.
0xA3