[C#] How to Validate XML Against Schema (XSD)? Something is wrong.

Question

Hello, I do not know enough about the XML namespace to see my error. Do you?

    public static bool ValidateXml(string xml, string xsd)
    {
        try
        {
            // build XSD schema

            StringReader _XsdStream;
            _XsdStream = new StringReader(xsd);

            XmlSchema _XmlSchema;
            _XmlSchema = XmlSchema.Read(_XsdStream, null);

            // build settings (this replaces XmlValidatingReader)

            XmlReaderSettings _XmlReaderSettings;
            _XmlReaderSettings = new XmlReaderSettings()
            {
                ValidationType = ValidationType.Schema
            };
            _XmlReaderSettings.Schemas.Add(_XmlSchema);

            // build XML reader

            StringReader _XmlStream;
            _XmlStream = new StringReader(xml);

            XmlReader _XmlReader;
            _XmlReader = XmlReader.Create(_XmlStream, _XmlReaderSettings);

            // validate

            using (_XmlReader)
            {
                while (_XmlReader.Read())
                    ;
            }

            // validation succeeded

            return true;
        }
        catch
        {
            // validation failed

            return false;
        }
    }

Here's the XSD

<xs:schema attributeFormDefault="unqualified" elementFormDefault="qualified" targetNamespace="http://server.com/www/content" xmlns:xs="http://www.w3.org/2001/XMLSchema"&gt;
<xs:element name="ads">
  <xs:complexType>
    <xs:sequence>
      <xs:element maxOccurs="unbounded" name="ad">
        <xs:complexType>
          <xs:attribute name="id" type="xs:string" use="required" />
          <xs:attribute name="date" type="xs:string" use="required" />
          <xs:attribute name="checksum" type="xs:string" use="required" />
          <xs:attribute name="size" type="xs:string" use="required" />
          <xs:attribute name="expanded-size" type="xs:string" use="required" />
        </xs:complexType>
      </xs:element>
    </xs:sequence>
    <xs:attribute name="last-modified" type="xs:string" use="required" />
  </xs:complexType>
</xs:element>
</xs:schema>

Here's the XML

<?xml version="1.0" encoding="UTF-8" ?>
<ads xmlns="http://server.com/www/content" last-modified="">
    <ad id="ad1" date="" checksum="" size="" expanded-size=""/>
    <ad id="ad2" date="" checksum="" size="" expanded-size=""/>
    <ad id="ad3" date="" checksum="" size="" expanded-size=""/>
</ads>

The method should return false, but it is returning true.

Honestly, I am not sure where to begin to debug this. :S

Thank you in advance for your time and answer.

Answer 1

Replace the XMLReader with XmlValidatingReader for validating. See: http://msdn.microsoft.com/en-us/library/system.xml.xmlvalidatingreader_members%28v=VS.71%29.aspx