Cannot Pass All jQuery 1.4.2 Ajax Unit Tests With my Plug-in

Question

I've created a plug-in that duck-punches the jQuery Ajax function. One problem that I cannot locate when running the Ajax unit tests for 1.4.2 It will not pass the two tests

1. Ajax events with context
2. jQuery.ajax context modification

Test one has a test that always fails:

 function callback(msg){
  return function(){
   equals( this, context, "context is preserved on callback " + msg );
  };
 }

The this reference instead of being the <div/> tag becomes an XPC Cross Origin Wrapper.

My Source Code is here:

My unit tests for the plug-in can be run here:

The failing unit tests can be run here:

One note is that jQuery 1.4.2 Ajax doe not handle a server response of 301 with FireFox 3.6.8. It will be returned as 0. I've modified my jQuery Library to account for this.

Also some JSONP stop watch timing. BUG #5383.

And maybe some presentation issues and this plug-in will be ready for the wild.

Any help would be appreciated. including design. Thanks in advance.

Answer 1

The problem is you're losing context in your service.monitor methods when calling the originally passed success, error, beforeSend and complete handlers.

Take a look in ajaxMonitor.service.js, you need to replace each of the original handler invocations with a .call() to maintain the proper context:

1) In service.monitorSuccess():

origSuccess(data, textStatus, request);
//should be:
origSuccess.call(this, data, textStatus, request);

2) In service.monitorError():

origError(request, status, errorThrown);
//should be:
origError.call(this, request, status, errorThrown);

3) In service.monitorBeforeSend():

var abortEarly = origBeforeSend(request);
//should be:
var abortEarly = origBeforeSend.call(this, request);

4) In service.monitorComplete():

var xhr = origComplete(request, status);
//should be:
var xhr = origComplete.call(this, request, status);

---

I copied your test setup here so you can see the results: http://ncraver.com/AjaxTest/

Notice some other tests are failing...these are unrelated to my changes, they're the result of the my site not running PHP, so tests are getting an improper response from those .php pages :)