views:

116

answers:

1

I want to create a jQuery dialog on-the-fly. I'm using this:

var newDiv = $(document.createElement('div')); 
$(newDiv).html('hello there');
$(newDiv).dialog();

I then have this in the html header:

<script type="text/javascript" src="js/jquery-1.4.2.min.js"></script>
<script type="text/javascript" src="js/jquery-ui-1.8.1.custom.min.js"></script>

When I try running the JS in IE7 I get the following error on the $(newDiv).dialog(); line : Object doesn't support this property or method.

Anyone know what's going on?

+3  A: 

Your code works, you can test it here, that means you probably have a script include problem, make sure that your files are under a js folder beside the page, or if you intended them to be from site root, use /js instead.

Or, consider using a CDN.

You can make your code a bit more efficient (I realize it's just a test), like this:

var newDiv = $(document.createElement('div')); 
newDiv.html('hello there');
newDiv.dialog();

This works because newDiv is already a jQuery element, no reason to clone the object each time...or a bit shorter:

$('<div />').html('hello there').dialog();
Nick Craver
+1 for demo and speed speed speed :)
Sarfraz
I do already have a js folder under the root which contains jquery-1.4.2.min.js and jquery-ui-1.8.1.custom.min.js. I also have some other jQuery stuff (Tabs) which are working fine. Doesn't this mean that my jQuery references are ok?The code gets called via an onclick event for a button.
DEH
I replaced my js references with the following:<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.min.js"></script><script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8/jquery-ui.min.js"></script>and it all started working. Do I need some additional .js files in my js folder, even though they're not directly references via a script tag?
DEH
@DEH - Nope that's it if what you're using is all jQuery and jQuery UI, everything is in those 2 files as far as the script goes. You may also want to include the CSS for jQuery UI the same way. Take a look at this question for those URLs: http://stackoverflow.com/questions/1348559/are-there-hosted-jquery-ui-themes-anywhere just replace the `1.7.0` in the URL of whatever theme you want to use with `1.8` (to match your jQuery UI script version), for example: http://ajax.googleapis.com/ajax/libs/jqueryui/1.8/themes/base/jquery-ui.css
Nick Craver
Just to confirm, my js/jquery-ui-1.8.1.custom.min.js file was a custom js download that did NOT include the jQuery Dialog stuff. Once I had created a new download containing the Dialog elements then it all worked with my own internal .js references.
DEH