ansaurus

Question

Why isn't this form updating the database?

Answer 1

+4 A:

You have a form nested inside of another form. I'd start there.

Edit: What's probably happening is that the first (empty) form is what is being submitted. Since it submits to the same page formbeta2.html, your PHP and SQL are never even being run. Please answer the question in my comment and we can help further from there.

jasonbar 2010-08-12 19:28:46

indeed. Two <form and one </form.

Iznogood 2010-08-12 19:30:35

Thanks, I didn't realize the nested form.

omgzor 2010-08-12 21:55:52

I took it out, but it's still not working. I'll rephrase the question and repost it.

omgzor 2010-08-12 22:16:02

Answer 2

A:

Where I would start is to separate the business logic and the presentation (the PHP code and the HTML). Putting business logic inside the HTML code is usually a bad idea.

There is a simple trick what I like to use: in PHP, you can very easily make template files. A very basic template system can be:

function render($file, $variables) {
  ob_start();
  extract($variables);
  if(file_exists($file)) {
    include $file;
  }
  return ob_end_clean();
}

Also, remember that trusing in the user input is a bad idea, so never ever substitute user supplied data directly into the an SQL string. In a case of MySQL, use mysql_real_escape_string().

$sql = 'INSERT INTO table(col) VALUES(\'' . mysql_real_escape_string($value) . '\');'

This technique is one of the most essential thing in web security.

Yorirou 2010-08-12 19:46:43

Answer 3

+2 A:

Looking at the HTML, the </form> is outside the </body> tag. Change this to:

</form>
</body>

Then, you need to remove the <form> that is right under the <body> tag since you already have it later.

Once you make those changes, everything else looks like it should work just fine.

Buena Suerte!

cdburgess 2010-08-12 20:04:10

Thanks, this solved the issue.

omgzor 2010-08-12 22:19:11

ansaurus

tags:

views:

answers:

Why isn't this form updating the database?

related questions