ansaurus

Question

JSF2 composite component: action isn't recognized

Answer 1

A:

Odd, I can't reproduce this with Mojarra 2.0.2. Maybe there's something more into the code which is colliding with one or other? Or you aren't running the code you think you're running?

For the sake of completeness, I'll include the test snippets I used to try to reproduce this problem:

/resources/components/test.xhtml

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"
    xmlns:h="http://java.sun.com/jsf/html"
    xmlns:cc="http://java.sun.com/jsf/composite"&gt;
    <cc:interface>
        <cc:attribute name="action" method-signature="java.lang.String action()" required="true" />
    </cc:interface>
    <cc:implementation>
        <h:form>
            <h:commandButton value="submit" action="#{cc.attrs.action}" />
        </h:form> 
    </cc:implementation>
</html>

/test.xhtml

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml" 
    xmlns:h="http://java.sun.com/jsf/html" 
    xmlns:cc="http://java.sun.com/jsf/composite/components"&gt;
    <h:head>
        <title>Test</title>
    </h:head>
    <h:body>
        <cc:test action="#{bean.submit}" />
    </h:body>
</html>

com.example.Bean

package com.example;

import javax.faces.bean.ManagedBean;
import javax.faces.bean.RequestScoped;

@ManagedBean
@RequestScoped
public class Bean {

    public String submit() {
        System.out.println("submit");
        return null;
    }

}

Does the above work for you as well?

BalusC 2010-08-15 20:47:09

That works just fine for me, even using CDI. I'll have to look into it further.

Zack 2010-08-16 15:41:44

Maybe a nested form? See also [this answer](http://stackoverflow.com/questions/2118656/hcommandlink-is-not-being-invoked/2120183#2120183) for another hints.

BalusC 2010-08-16 16:02:36

There's definitely not a nested form...I **do** use CDI in the bean (I inject 3 different beans from two different scopes. Also, I use required view parameters. I'm not sure if any of this makes a difference. I don't imagine it would since issues with insantiation or view parameters would throw exceptions well before the point of actually trying to call the action.

Zack 2010-08-16 16:17:01

Answer 2

+1 A:

Hello Zack

I had the same problem and I found out that it was due to that my action method did throw IllegalArgumentException. The tricky part (at least for me) was that my app had been working fine until I moved part of the code into a Composite Component (CC). Before my app would caught the IAE and show a nice error message but when using CC, the JSF validation (or whatever...) catches this first and produce this rather confusing error message.

I verified this by using a modified version of the test code provided by BalusC (See below). The test page shows two input & submit button components. If you enter something in the text field (apart from "panic" (without quotes)), both the CC-version and the "inline" version works (watch the std output). If you enter "panic" in the "inlined" version, you'll notice the IAE as expected, but if you enter the same thing in the upper "CC-version" you'll see the PropertyNotFoundException instead. Seems that JSF gets confused by the IAE and decides that the attribute must be a property and not an action method after all... Not sure if this is a bug or a feature. Is this according to Spec, does anybody know?

So, the conclusion here is that you can't use action methods in CC with beans that throw exceptions. For me, this means that I can't use Composite Components. Sad!

Hope this helps...

/resources/components/test.xhtml

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:h="http://java.sun.com/jsf/html"
      xmlns:cc="http://java.sun.com/jsf/composite"&gt;
<cc:interface>
  <cc:attribute name="text"/>
  <cc:attribute name="action" method-signature="java.lang.String action()" required="true" />
</cc:interface>
<cc:implementation>
  <h:form>
    <h:inputText value="#{cc.attrs.text}"/>
    <h:commandButton value="submit" action="#{cc.attrs.action}" />
  </h:form>
</cc:implementation>

/test.xhtml

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:h="http://java.sun.com/jsf/html"
      xmlns:cc="http://java.sun.com/jsf/composite/components"&gt;
<h:head>
  <title>Test</title>
</h:head>
<h:body>
  <!-- text and cmd-button as cc -->
  <cc:test text="#{bean.text}" action="#{bean.submit}" />

  <hr/>

  <!-- text and cmd-buuton inline -->
  <h:form id="inline">
    <h:inputText value="#{bean.text}"/>
    <h:commandButton value="submit2" action="#{bean.submit}" />
  </h:form>
</h:body>
</html>

And last the Bean:

@ManagedBean
@RequestScoped
public class Bean {

  private String text;

  public String getText() {
    return text;
  }

  public void setText(String text) {
    this.text = text;
  }

  public String submit() {
        if (text.equalsIgnoreCase("panic")){
          throw new IllegalArgumentException("Panic!");
        }

        System.out.println(text);

        return null;
    }
}

Jorgen 2010-09-14 09:56:12

Of course, you could add a Faces Message instead of throwing IAE:

Jorgen 2010-09-14 10:51:21

FacesContext.getCurrentInstance().addMessage(null, new FacesMessage("Some error...."); But this break the separation of beans (as simple POJOs) and JSF/Faces

Jorgen 2010-09-14 10:52:54

You're entirely right! This is definitely a bug. I'll report this to the JSF boys.

BalusC 2010-09-14 11:29:07

And reported: https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1806

BalusC 2010-09-14 11:41:55

ansaurus

tags:

views:

answers:

JSF2 composite component: action isn't recognized

related questions