ansaurus

Question

Answer 1

+2 A:

You have a lot of unnecessary code in your showKeyCode function. The following will do just as well; you're already guaranteed that e will refer to the key event object becuase of the way you're passing in event in the body's onkeydown attribute, and there's no need for any browser sniffing at all. return false is the correct way to prevent the browser's default action when using a DOM0 key handler, so no need for e.returnValue.

You'll have problems blocking F5 and unless you have a seriously good reason you shouldn't do it anyway, since the user is used to it performing a page refresh. If you change the function to the following then there's no reason why it shouldn't prevent the Enter key's default action:

function showKeyCode(e) {
    if (e.keyCode == 13) {
        return false;
    }
}

Tim Down 2010-08-17 22:21:33

Don't block F5, use a onbefore unload handler to make sure the user knows they are going to lose changes, they can cancel the refresh if they want to. This will work for back button, close window, navigate away.I would strongly consider using jquery, ext-core, prototype which do the normalization of keyboard event data for you.The best reference with keyboard handling across platforms/browsers http://unixpapa.com/js/key.html

Juan Mendes 2010-08-17 23:53:18

There's no need for a framework for this. My answer will work in all the major browsers released in the last decade.

Tim Down 2010-08-18 00:34:21

I made a huge mistake when I started this project...I used XHTML-compliant script tags, instead of the usual <script></script> which seems to explain why these scripts were working in Chrome and in none of the other browsers...

dll32 2010-08-18 12:27:00

ansaurus

tags:

views:

answers:

Can't block keys using event listener

related questions